From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 01/26] genirq: add irq_domain-aware core IRQ handler Date: Tue, 26 Aug 2014 11:46:38 -0700 Message-ID: <53FCD60E.1030009@codeaurora.org> References: <1409047421-27649-1-git-send-email-marc.zyngier@arm.com> <1409047421-27649-2-git-send-email-marc.zyngier@arm.com> <53FCC714.3090206@codeaurora.org> <53FCCCC7.9070801@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53FCCCC7.9070801@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Marc Zyngier Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux@openrisc.net" , "linux@arm.linux.org.uk" , "shawn.guo@freescale.com" , "kernel@pengutronix.de" , "tony@atomide.com" , Catalin Marinas , Will Deacon , "jonas@southpole.se" , "tglx@linutronix.de" , "jason@lakedaemon.net" , "shc_work@mail.ru" , "baohua@kernel.org" , "maxime.ripard@free-electrons.com" , "khilman@linaro.org" , Lorenzo Pieralisi List-Id: linux-omap@vger.kernel.org On 08/26/14 11:07, Marc Zyngier wrote: > Digging into my email, one of the traces looked like this: > > stack backtrace: > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.16.0-rc1+ #135 > Call trace: > [] dump_backtrace+0x0/0x12c > [] show_stack+0x10/0x1c > [] dump_stack+0x74/0xc4 > [] lockdep_rcu_suspicious+0xe8/0x124 > [] irq_find_mapping+0x16c/0x198 > [] gic_handle_irq+0x38/0xcc > > Most drivers call irq_find_mapping outside of irq_enter()/irq_exit(), as > this is in handle_IRQ(). > Ah ok. This is the multi-irq handler case? Has this been broken since v3.2 at least for the gic users? Now that we call irq_enter()/irq_exit() a lot more code runs, including things like updating jiffies when interrupts arrive and invoking softirq? Do we only call irq_exit() on the IPI path otherwise? Are there any plans to send this back to stable trees? Not calling irq_enter()/irq_exit() when we get an interrupt seems like a big problem. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation