linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: tony@atomide.com
Cc: pekon@pek-sem.com, linux-omap@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: dra7-evm: Fix NAND GPMC timings (for 3.17)
Date: Mon, 8 Sep 2014 11:08:07 +0300	[thread overview]
Message-ID: <540D63E7.7000907@ti.com> (raw)
In-Reply-To: <1409918662-20547-1-git-send-email-rogerq@ti.com>

Hi Tony,

This is needed for 3.17 otherwise NAND is broken on dra7-evm. Thanks.

cheers,
-roger

On 09/05/2014 03:04 PM, Roger Quadros wrote:
> The nand timings were scaled down by 2 to account for
> the 2x rate returned by clk_get_rate(gpmc_fclk).
> 
> As the clock data got fixed by [1], revert back to actual
> timings (i.e. scale them up by 2).
> 
> Without this NAND doesn't work on dra7-evm.
> 
> [1] - commit dd94324b983afe114ba9e7ee3649313b451f63ce
>     ARM: dts: dra7xx-clocks: Fix the l3 and l4 clock rates
> 
> Fixes: ff66a3c86e00 ("ARM: dts: dra7: add support for parallel NAND flash")
> Cc: <stable@vger.kernel.org>        [3.16]
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/boot/dts/dra7-evm.dts | 27 ++++++++++++---------------
>  1 file changed, 12 insertions(+), 15 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> index 990ee6a..a120d8f 100644
> --- a/arch/arm/boot/dts/dra7-evm.dts
> +++ b/arch/arm/boot/dts/dra7-evm.dts
> @@ -427,22 +427,19 @@
>  		gpmc,device-width = <2>;
>  		gpmc,sync-clk-ps = <0>;
>  		gpmc,cs-on-ns = <0>;
> -		gpmc,cs-rd-off-ns = <40>;
> -		gpmc,cs-wr-off-ns = <40>;
> +		gpmc,cs-rd-off-ns = <80>;
> +		gpmc,cs-wr-off-ns = <80>;
>  		gpmc,adv-on-ns = <0>;
> -		gpmc,adv-rd-off-ns = <30>;
> -		gpmc,adv-wr-off-ns = <30>;
> -		gpmc,we-on-ns = <5>;
> -		gpmc,we-off-ns = <25>;
> -		gpmc,oe-on-ns = <2>;
> -		gpmc,oe-off-ns = <20>;
> -		gpmc,access-ns = <20>;
> -		gpmc,wr-access-ns = <40>;
> -		gpmc,rd-cycle-ns = <40>;
> -		gpmc,wr-cycle-ns = <40>;
> -		gpmc,wait-pin = <0>;
> -		gpmc,wait-on-read;
> -		gpmc,wait-on-write;
> +		gpmc,adv-rd-off-ns = <60>;
> +		gpmc,adv-wr-off-ns = <60>;
> +		gpmc,we-on-ns = <10>;
> +		gpmc,we-off-ns = <50>;
> +		gpmc,oe-on-ns = <4>;
> +		gpmc,oe-off-ns = <40>;
> +		gpmc,access-ns = <40>;
> +		gpmc,wr-access-ns = <80>;
> +		gpmc,rd-cycle-ns = <80>;
> +		gpmc,wr-cycle-ns = <80>;
>  		gpmc,bus-turnaround-ns = <0>;
>  		gpmc,cycle2cycle-delay-ns = <0>;
>  		gpmc,clk-activation-ns = <0>;
> 

  reply	other threads:[~2014-09-08  8:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 12:04 [PATCH] ARM: dts: dra7-evm: Fix NAND GPMC timings Roger Quadros
2014-09-08  8:08 ` Roger Quadros [this message]
2014-09-08 22:40   ` [PATCH] ARM: dts: dra7-evm: Fix NAND GPMC timings (for 3.17) Tony Lindgren
2014-09-22  8:58     ` Roger Quadros
2014-09-23 16:03       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540D63E7.7000907@ti.com \
    --to=rogerq@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=pekon@pek-sem.com \
    --cc=stable@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).