From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Roger Quadros <rogerq@ti.com>, tony@atomide.com
Cc: wg@grandegger.com, mugunthanvnm@ti.com, george.cherian@ti.com,
balbi@ti.com, nsekhar@ti.comnm@ti.com,
sergei.shtylyov@cogentembedded.com, linux-omap@vger.kernel.org,
linux-can@vger.kernel.org
Subject: Re: [PATCH v2 02/12] ARM: dts: DRA7: Add DCAN nodes
Date: Tue, 09 Sep 2014 17:04:34 +0200 [thread overview]
Message-ID: <540F1702.2000007@pengutronix.de> (raw)
In-Reply-To: <1410274534-22826-3-git-send-email-rogerq@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2163 bytes --]
On 09/09/2014 04:55 PM, Roger Quadros wrote:
> The SoC supports 2 DCAN nodes. Add them.
I think you should put the device-tree ml for DT related patches on Cc.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> arch/arm/boot/dts/dra7.dtsi | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 370009e..09d5739 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -34,6 +34,8 @@
> serial3 = &uart4;
> serial4 = &uart5;
> serial5 = &uart6;
> + d_can0 = &dcan1;
> + d_can1 = &dcan2;
> };
>
> timer {
> @@ -1267,6 +1269,34 @@
> ti,irqs-skip = <10 133 139 140>;
> ti,irqs-safe-map = <0>;
> };
> +
> + dcan1: can@481cc000 {
> + compatible = "bosch,d_can";
> + ti,hwmods = "dcan1";
> + reg = <0x4ae3c000 0x2000>,
> + <0x558 0x4>; /* index to RAMINIT reg within syscon */
Putting the offset within the syscon here doesn't look good.
> + ti,raminit-syscon = <&dra7_ctrl_core>;
Why not add it as a second parameter to the ti,raminit-syscon instead?
> + ti,raminit-start-bit = <3>;
> + ti,raminit-done-bit = <1>;
> + ti,raminit-pulse;
> + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&dcan1_sys_clk_mux>;
> + status = "disabled";
> + };
> +
> + dcan2: can@481d0000 {
> + compatible = "bosch,d_can";
> + ti,hwmods = "dcan2";
> + reg = <0x48480000 0x2000>,
> + <0x558 0x4>; /* index to RAMINIT reg within syscon */
> + ti,raminit-syscon = <&dra7_ctrl_core>;
> + ti,raminit-start-bit = <5>;
> + ti,raminit-done-bit = <2>;
> + ti,raminit-pulse;
> + interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&sys_clkin1>;
> + status = "disabled";
> + };
> };
> };
>
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2014-09-09 15:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 14:55 [PATCH v2 00/12] ARM: dts: TI: Add DCAN support Roger Quadros
2014-09-09 14:55 ` [PATCH v2 01/12] ARM: dts: dra7: Add syscon regmap for CORE CONTROL area Roger Quadros
2014-09-09 14:55 ` [PATCH v2 02/12] ARM: dts: DRA7: Add DCAN nodes Roger Quadros
2014-09-09 15:04 ` Marc Kleine-Budde [this message]
2014-09-09 15:06 ` Marc Kleine-Budde
2014-09-10 8:06 ` Roger Quadros
2014-09-09 14:55 ` [PATCH v2 03/12] ARM: dts: dra7-evm: Add CAN support Roger Quadros
2014-09-09 14:55 ` [PATCH v2 04/12] ARM: dts: dra72-evm: " Roger Quadros
2014-09-09 14:55 ` [PATCH v2 05/12] arm: dts: am4372: Add dcan nodes Roger Quadros
2014-09-09 15:09 ` Marc Kleine-Budde
2014-09-10 8:08 ` Roger Quadros
2014-09-09 14:55 ` [PATCH v2 06/12] ARM: dts: AM43xx: Add aliases to d_can nodes Roger Quadros
2014-09-09 15:08 ` Marc Kleine-Budde
2014-09-10 8:08 ` Roger Quadros
2014-09-09 14:55 ` [PATCH v2 07/12] arm: dts: am437x-gp: Add dcan support Roger Quadros
2014-09-09 14:55 ` [PATCH v2 08/12] ARM: dts: am437x-gp-evm: Add pinctrl sleep states for dcan pins Roger Quadros
2014-09-09 14:55 ` [PATCH v2 09/12] ARM: dts: am4372: Add control module syscon node Roger Quadros
2014-09-09 14:55 ` [PATCH v2 10/12] ARM: dts: am4372: Add dcan raminit bits Roger Quadros
2014-09-09 14:55 ` [PATCH v2 11/12] ARM: dts: am33xx: Add control module syscon node Roger Quadros
2014-09-09 14:55 ` [PATCH v2 12/12] ARM: dts: am33xx: Add dcan raminit bits Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540F1702.2000007@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.comnm \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).