From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH v10 5/9] arm: omap1: Migrate debug_ll macros to use 8250.S Date: Tue, 16 Sep 2014 16:05:08 -0700 Message-ID: <5418C224.8050504@linaro.org> References: <1410907588-19957-1-git-send-email-daniel.thompson@linaro.org> <1410907588-19957-6-git-send-email-daniel.thompson@linaro.org> <20140916225810.GA1273@drone.musicnaut.iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:57503 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752512AbaIPXFI (ORCPT ); Tue, 16 Sep 2014 19:05:08 -0400 Received: by mail-pa0-f41.google.com with SMTP id bj1so761427pad.28 for ; Tue, 16 Sep 2014 16:05:07 -0700 (PDT) In-Reply-To: <20140916225810.GA1273@drone.musicnaut.iki.fi> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Aaro Koskinen Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, Arnd Bergmann , Paul Bolle , patches@linaro.org, linaro-kernel@lists.linaro.org, Tony Lindgren , Arnd Bergmann , linux-omap@vger.kernel.org On 16/09/14 15:58, Aaro Koskinen wrote: > Hi, > > On Tue, Sep 16, 2014 at 11:46:24PM +0100, Daniel Thompson wrote: >> + config DEBUG_OMAP1UART1 >> + bool "Kernel low-level debugging via OMAP1 UART1" >> + depends on ARCH_OMAP1 >> + select DEBUG_UART_8250 >> + help >> + Say Y here if you want kernel low-level debugging support >> + on OMAP1 based platforms (expect OMAP730) on the UART1. > ^^^^^^ > >> + select DEBUG_UART_8250 >> + help >> + Say Y here if you want kernel low-level debugging support >> + on OMAP1 based platforms (expect OMAP730) on the UART2. > ^^^^^^ > >> + select DEBUG_UART_8250 >> + help >> + Say Y here if you want kernel low-level debugging support >> + on OMAP1 based platforms (expect OMAP730) on the UART3. > ^^^^^^ > > I already commented earlier, that "expect" here is probably a typo? I'm extremely sorry to have overlooked your previous comment. There's certainly no question I read your previous e-mail because because I copied your Tested-by: from it. I will fix this (and also grep all other patches in the set to make sure I haven't copied the typo anywhere else). Daniel.