From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: vinod.koul@intel.com, dan.j.williams@intel.com,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume
Date: Wed, 17 Sep 2014 21:38:09 +0300 [thread overview]
Message-ID: <5419D511.5010801@ti.com> (raw)
In-Reply-To: <1410896757-3848-1-git-send-email-peter.ujfalusi@ti.com>
Vinod,
On 09/16/2014 10:45 PM, Peter Ujfalusi wrote:
> Hi,
>
> Changes since v2:
> - fix typo in patch two
> - Acked-by added from Russell
>
> When the audio is paused/resumed (application paused the sream or board suspend)
> the audio was only playing back one period worth of data and then stops because
> the omap_dam_stop() clears the link configuration and it is not restored in
> start.
>
> Also add memory barrier call to resume path since this could happen right after
> coming out from suspend.
Would it be possible to queue this two patch for 3.17?
This stop/start issue affects not only board suspend/resume, but in all cases
when application pauses the stream as well when we have underrun in ALSA
which would not trigger a full stop and start of audio.
Thanks,
Péter
> Regards,
> Peter
> ---
> Peter Ujfalusi (2):
> dmaengine: omap-dma: Add memory barrier to dma_resume path
> dmaengine: omap-dma: Restore the CLINK_CTRL in resume path
>
> drivers/dma/omap-dma.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
next prev parent reply other threads:[~2014-09-17 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 19:45 [PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume Peter Ujfalusi
2014-09-16 19:45 ` [PATCH v3 1/2] dmaengine: omap-dma: Add memory barrier to dma_resume path Peter Ujfalusi
2014-09-16 19:45 ` [PATCH v3 2/2] dmaengine: omap-dma: Restore the CLINK_CTRL in resume path Peter Ujfalusi
2014-09-17 18:38 ` Peter Ujfalusi [this message]
2014-09-23 12:53 ` [PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5419D511.5010801@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).