From: Lars-Peter Clausen <lars@metafoo.de>
To: Dan Murphy <dmurphy@ti.com>,
broonie@kernel.org, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] regmap: Allow read_reg_mask to be 0
Date: Tue, 30 Sep 2014 23:03:58 +0200 [thread overview]
Message-ID: <542B1ABE.5000900@metafoo.de> (raw)
In-Reply-To: <1412093220-24690-1-git-send-email-dmurphy@ti.com>
On 09/30/2014 06:07 PM, Dan Murphy wrote:
> There may be spi devices that do not require a
> register read mask to read the registers.
>
> Currently the code sets the read mask based on
> a non-zero value passed in from the driver or if that
> value is 0 sets the read mask to 0x80.
It only sets it to the bus default if both read_flag_mask and
write_flag_mask are 0. The assumption is that both of them being zero is a
invalid configuration and either of them (or both) have to be non-zero for
proper operation, since otherwise the device can't tell the difference
between a read and a write.
Do you have a device where both the read and the write mask is 0?
- Lars
next prev parent reply other threads:[~2014-09-30 21:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 16:07 [PATCH] regmap: Allow read_reg_mask to be 0 Dan Murphy
2014-09-30 17:25 ` Mark Brown
2014-09-30 20:19 ` Dan Murphy
2014-09-30 20:20 ` Dan Murphy
2014-09-30 20:39 ` Dan Murphy
2014-09-30 21:03 ` Lars-Peter Clausen [this message]
2014-09-30 21:18 ` Dan Murphy
2014-09-30 21:29 ` Lars-Peter Clausen
2014-10-01 11:15 ` Mark Brown
2014-10-01 11:39 ` Dan Murphy
2014-10-01 16:30 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542B1ABE.5000900@metafoo.de \
--to=lars@metafoo.de \
--cc=broonie@kernel.org \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).