Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: linux-omap@vger.kernel.org, tony@atomide.com, nm@ti.com,
	lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] regulator: twl: use platform data in the DT based boot also
Date: Fri, 10 Oct 2014 16:43:42 +0300	[thread overview]
Message-ID: <5437E28E.8020500@ti.com> (raw)
In-Reply-To: <1412948442-19896-3-git-send-email-t-kristo@ti.com>

On 10/10/2014 04:40 PM, Tero Kristo wrote:
> This allows to pass platform information during a DT boot also, currently
> this is completely ignored. Needed for supporting the platform specific
> regulator set_voltage / get_voltage ops for the SMPS regulators.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> To: Liam Girdwood <lgirdwood@gmail.com>
> To: Mark Brown <broonie@kernel.org>

Ok that "To:" didn't really work too well, added manually. Can repost if 
needed.

-Tero

> ---
>   drivers/regulator/twl-regulator.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
> index 0b4f866..2c4fa06 100644
> --- a/drivers/regulator/twl-regulator.c
> +++ b/drivers/regulator/twl-regulator.c
> @@ -1103,9 +1103,9 @@ static int twlreg_probe(struct platform_device *pdev)
>   	if (match) {
>   		template = match->data;
>   		id = template->desc.id;
> +		drvdata = dev_get_platdata(&pdev->dev);
>   		initdata = of_get_regulator_init_data(&pdev->dev,
>   						      pdev->dev.of_node);
> -		drvdata = NULL;
>   	} else {
>   		id = pdev->id;
>   		initdata = dev_get_platdata(&pdev->dev);
>


  parent reply	other threads:[~2014-10-10 13:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10 13:40 [PATCH 0/2] ARM: OMAP3+: VCVP mapping fixes to get DVFS working Tero Kristo
2014-10-10 13:40 ` [PATCH 1/2] ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks Tero Kristo
2014-10-10 17:00   ` Tony Lindgren
2014-10-10 17:54     ` Tero Kristo
2014-10-10 13:40 ` [PATCH 2/2] regulator: twl: use platform data in the DT based boot also Tero Kristo
2014-10-10 13:43   ` Nishanth Menon
2014-10-10 13:43   ` Tero Kristo [this message]
2014-10-10 13:48     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5437E28E.8020500@ti.com \
    --to=t-kristo@ti.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox