From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Roger Quadros <rogerq@ti.com>, wg@grandegger.com
Cc: wsa@the-dreams.de, tony@atomide.com, tglx@linutronix.de,
mugunthanvnm@ti.com, george.cherian@ti.com, balbi@ti.com,
nsekhar@ti.comnm@ti.com, sergei.shtylyov@cogentembedded.com,
linux-omap@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 7/8] net: can: c_can: Add support for TI DRA7 DCAN
Date: Wed, 05 Nov 2014 14:43:39 +0100 [thread overview]
Message-ID: <545A298B.6090505@pengutronix.de> (raw)
In-Reply-To: <545A27E8.9090600@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
On 11/05/2014 02:36 PM, Roger Quadros wrote:
> On 11/05/2014 03:30 PM, Marc Kleine-Budde wrote:
>> On 11/04/2014 11:21 AM, Roger Quadros wrote:
>>> DRA7 SoC has 2 CAN IPs. Provide compatible IDs and RAMINIT
>>> register data for both.
>>
>> My understanding of the discussion with Wolfram was:
>> - We should put the number of the Interface into to DT as a regmap
>> parameter.
>> - We put the method how to find the correct bits into the DT, via the
>> compatible.
>>
>> So for both CAN instances on the DRA7 we have a single compatible
>> "ti,dra7-d_can" and in the driver a mechanism that translates the number
>> of the instance into the needed bit offsets, e.g. via two arrays.
>>
>
> OK. I'll revise this series.
>
> The new syscon-raminit property will be like
> syscon-raminit = <syscon_phandle raminit-reg-offset dcan-interface-number>;
Yes. Wolfram?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-05 13:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 10:20 [PATCH v3 0/8] net: can: Use syscon regmap for TI specific RAMINIT register Roger Quadros
2014-11-04 10:20 ` [PATCH v3 1/8] net: can: c_can: Add timeout to c_can_hw_raminit_ti() Roger Quadros
2014-11-04 10:20 ` [PATCH v3 2/8] net: can: c_can: Introduce c_can_driver_data structure Roger Quadros
2014-11-04 10:20 ` [PATCH v3 3/8] net: can: c_can: Add RAMINIT register information to driver data Roger Quadros
2014-11-04 10:20 ` [PATCH v3 4/8] net: can: c_can: Add syscon/regmap RAMINIT mechanism Roger Quadros
2014-11-05 11:37 ` Roger Quadros
2014-11-04 10:20 ` [PATCH v3 5/8] net: can: c_can: Add support for START pulse in RAMINIT sequence Roger Quadros
2014-11-04 10:20 ` [PATCH v3 6/8] net: can: c_can: Disable pins when CAN interface is down Roger Quadros
2014-11-05 13:24 ` Marc Kleine-Budde
2014-11-05 13:33 ` Roger Quadros
2014-11-04 10:21 ` [PATCH v3 7/8] net: can: c_can: Add support for TI DRA7 DCAN Roger Quadros
2014-11-05 13:30 ` Marc Kleine-Budde
2014-11-05 13:36 ` Roger Quadros
2014-11-05 13:43 ` Marc Kleine-Budde [this message]
2014-11-04 10:21 ` [PATCH v3 8/8] net: can: c_can: Add support for TI am3352 DCAN Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A298B.6090505@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.comnm \
--cc=rogerq@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).