From: Nishanth Menon <nm@ti.com>
To: Keerthy <j-keerthy@ti.com>, linux-omap@vger.kernel.org
Cc: tony@atomide.com
Subject: Re: [PATCH 0/2] bus: omap_l3_noc: Add resume hook to restore mask registers
Date: Mon, 10 Nov 2014 09:29:25 -0600 [thread overview]
Message-ID: <5460D9D5.2040108@ti.com> (raw)
In-Reply-To: <1415595784-5646-1-git-send-email-j-keerthy@ti.com>
On 11/09/2014 11:03 PM, Keerthy wrote:
> l3_noc module loses context during both DS0 and RTC+DDR in self refresh modes.
> This causes the previously masked l3 interrupts to trigger and the software
> book keeping assumes the interrupts are masked and does nothing to mask.
> This software/hardware out of sync leads to back to back l3 interrupts
> and eventually causes a hang. Hence adding resume hook to restore the
> mask registers based on the book keeping variables
>
> Keerthy (2):
> bus: omap_l3_noc: Add resume hook to restore context
minor comment on this patch,
> bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in
> the irq handler
>
> drivers/bus/omap_l3_noc.c | 63 +++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 61 insertions(+), 2 deletions(-)
>
Otherwise:
Acked-by: Nishanth Menon <nm@ti.com>
yep, AM437x did bring out some interesting surprises :(... thanks for
catching them.
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2014-11-10 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 5:03 [PATCH 0/2] bus: omap_l3_noc: Add resume hook to restore mask registers Keerthy
2014-11-10 5:03 ` [PATCH 1/2] bus: omap_l3_noc: Add resume hook to restore context Keerthy
2014-11-10 15:28 ` Nishanth Menon
2014-11-10 5:03 ` [PATCH 2/2] bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler Keerthy
2014-11-10 15:30 ` Nishanth Menon
2014-11-10 15:29 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460D9D5.2040108@ti.com \
--to=nm@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).