From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Takashi Iwai <tiwai@suse.de>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Cc: kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: ASoC: omap-mcbsp: Deletion of an unnecessary check before the function call "kfree"
Date: Mon, 17 Nov 2014 21:11:37 +0200 [thread overview]
Message-ID: <546A4869.6010209@bitmer.com> (raw)
In-Reply-To: <5469F4D5.9050908@users.sourceforge.net>
On 11/17/2014 03:15 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 17 Nov 2014 14:05:27 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> sound/soc/omap/mcbsp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2014-11-17 19:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.so urceforge.net>
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-11-17 13:15 ` ASoC: omap-mcbsp: Deletion of an unnecessary check before the function call "kfree" SF Markus Elfring
2014-11-17 19:11 ` Jarkko Nikula [this message]
2014-11-18 9:40 ` Mark Brown
2014-11-22 10:00 ` [PATCH 1/1] ARM: OMAP2: Deletion of unnecessary checks before three function calls SF Markus Elfring
2015-06-30 12:10 ` [PATCH] ARM: OMAP2: Delete " SF Markus Elfring
2015-07-16 5:55 ` Paul Walmsley
2015-07-16 6:23 ` Tony Lindgren
2015-07-16 14:06 ` Paul Walmsley
2015-07-16 16:28 ` Tony Lindgren
2015-07-16 6:40 ` SF Markus Elfring
2014-11-23 13:14 ` [PATCH 1/1] video: fbdev-OMAP2: Deletion of unnecessary checks before the function call "i2c_put_adapter" SF Markus Elfring
2015-02-03 10:21 ` [PATCH] ti-soc-thermal: Delete an unnecessary check before the function call "cpufreq_cooling_unregister" SF Markus Elfring
2015-06-25 11:33 ` [PATCH 0/2] ARM-OMAP2+: Deletion of unnecessary checks before two function calls SF Markus Elfring
2015-06-25 11:38 ` [PATCH 1/2] ARM-OMAP2+: Delete an unnecessary check before the function call "omap_device_delete" SF Markus Elfring
2015-06-25 11:40 ` [PATCH 2/2] ARM-OMAP2+: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring
2015-07-15 6:41 ` [PATCH 0/2] ARM-OMAP2+: Deletion of unnecessary checks before two function calls Tony Lindgren
2015-06-28 12:36 ` [PATCH] video: fbdev: omap2: displays-new: Delete a check before backlight_device_unregister() SF Markus Elfring
2016-07-23 17:09 ` [PATCH] memory: omap-gpmc: Delete an unnecessary check before the function call "gpiochip_free_own_desc" SF Markus Elfring
2016-08-01 9:32 ` Roger Quadros
2016-07-23 17:37 ` [PATCH] omapfb: panel-dsi-cm: Delete an unnecessary check before backlight_device_unregister() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546A4869.6010209@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cocci@systeme.lip6.fr \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).