From: Lars-Peter Clausen <lars@metafoo.de>
To: Tony Lindgren <tony@atomide.com>,
Apelete Seketeli <apelete@seketeli.net>
Cc: Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Fabio Baltieri <fabio.baltieri@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 5/8] usb: musb: Change end point selection to use new IO access
Date: Tue, 25 Nov 2014 16:02:46 +0100 [thread overview]
Message-ID: <54749A16.20204@metafoo.de> (raw)
In-Reply-To: <20141124235241.GH2817@atomide.com>
On 11/25/2014 12:52 AM, Tony Lindgren wrote:
> * Apelete Seketeli <apelete@seketeli.net> [141124 15:40]:
>> Hi Tony,
>>
>> Thanks for the patch.
>>
>> On Mon, Nov-24-2014 at 11:05:03 AM -0800, Tony Lindgren wrote:
>>> This allows the endpoints to work when multiple MUSB glue
>>> layers are built in.
>>
>> Applied on top of 3.18-rc6 mainline and tested successfully on JZ4740.
>> Been able to use ethernet-over-usb to access the internet on
>> device. No issue as far as I'm concerned.
>
> Great that's good to hear and thanks for testing.
>
> Doing the DMA patches here right now.. For the DMA, I've set up
> JZ4740 to use the MUSB_DMA_INVENTRA option by default, is that OK
> or do you have some other DMA hardware on it?
>
> If MUSB_DMA_INVENTRA does not work, and you don't have other DMA
> hardware on it, we can pass MUSB_DMA_INVENTRA and leave the DMA
> function pointers empty, and then the driver will bail out during
> init unless the option for CONFIG_MUSB_PIO_ONLY is set.
Yea... so according to the datasheet there is no DMA support, or at least it
is not documented in the datasheet's description of the USB core. There is a
vendor driver for the core which has ifdefs to enable DMA which looks like
MUSB_DMA_INVENTRA, but I think we never really go that to work too well. So
the current configuration is to use only PIO.
- Lars
next prev parent reply other threads:[~2014-11-25 15:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 19:04 [PATCH 0/8] Allow multiple MUSB glue layers to be built in Tony Lindgren
2014-11-24 19:05 ` [PATCH 2/8] usb: musb: Populate new IO functions for tusb6010 Tony Lindgren
2014-11-24 19:05 ` [PATCH 3/8] usb: musb: Populate new IO functions for blackfin Tony Lindgren
[not found] ` <1416855906-13931-1-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-11-24 19:04 ` [PATCH 1/8] usb: musb: Add function pointers for IO access functions Tony Lindgren
2014-11-24 19:05 ` [PATCH 4/8] usb: musb: Change to use new IO access Tony Lindgren
2014-11-24 19:12 ` Felipe Balbi
2014-11-24 19:26 ` Tony Lindgren
[not found] ` <1416855906-13931-5-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-11-25 9:46 ` Linus Walleij
2014-11-24 19:05 ` [PATCH 5/8] usb: musb: Change end point selection " Tony Lindgren
2014-11-24 23:38 ` Apelete Seketeli
2014-11-24 23:52 ` Tony Lindgren
2014-11-25 15:02 ` Lars-Peter Clausen [this message]
2014-11-28 13:50 ` Linus Walleij
2014-11-24 19:05 ` [PATCH 6/8] usb: musb: Pass fifo_mode in platform data Tony Lindgren
2014-11-24 23:40 ` Apelete Seketeli
2014-11-28 13:40 ` Linus Walleij
2014-11-24 19:05 ` [PATCH 7/8] usb: musb: Allow multiple glue layers to be built in Tony Lindgren
2014-11-24 19:05 ` [PATCH 8/8] usb: musb: Use IS_ENABLED for tusb6010 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54749A16.20204@metafoo.de \
--to=lars@metafoo.de \
--cc=apelete@seketeli.net \
--cc=balbi@ti.com \
--cc=fabio.baltieri@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).