[PATCH] arm: omap2: rx51-peripherals: fix build warning

[PATCH] arm: omap2: rx51-peripherals: fix build warning

[Felipe Balbi]

commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
si4713 platform data) updated board-rx51-peripherals.c
so that si4713 could be easily used on DT boot, but
it ended up introducing a build warning whenever
si4713 isn't enabled.

This patches fixes that warning:

arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
 static struct si4713_platform_data rx51_si4713_platform_data = {

Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index d18a5cf..bda20c5 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
 	.gpio_reset = 60,
 };
 
+#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
 static struct si4713_platform_data rx51_si4713_platform_data = {
 	.is_platform_device = true
 };
+#endif
 
 static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
 #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
-- 
2.1.0.GIT

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
> 
> This patches fixes that warning:
> 
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
>  static struct si4713_platform_data rx51_si4713_platform_data = {
> 
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>

Acked-By: Sebastian Reichel <sre@kernel.org>

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Hans Verkuil]

On 11/26/2014 09:27 PM, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
> 
> This patches fixes that warning:
> 
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
>  static struct si4713_platform_data rx51_si4713_platform_data = {
> 
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

> ---
>  arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index d18a5cf..bda20c5 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
>  	.gpio_reset = 60,
>  };
>  
> +#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
>  static struct si4713_platform_data rx51_si4713_platform_data = {
>  	.is_platform_device = true
>  };
> +#endif
>  
>  static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
>  #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
> 
> This patches fixes that warning:
> 
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
>  static struct si4713_platform_data rx51_si4713_platform_data = {
> 
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>

a gentle reminder on this one.

> ---
>  arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index d18a5cf..bda20c5 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
>  	.gpio_reset = 60,
>  };
>  
> +#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
>  static struct si4713_platform_data rx51_si4713_platform_data = {
>  	.is_platform_device = true
>  };
> +#endif
>  
>  static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
>  #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> -- 
> 2.1.0.GIT
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Arnd Bergmann]

On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > si4713 platform data) updated board-rx51-peripherals.c
> > so that si4713 could be easily used on DT boot, but
> > it ended up introducing a build warning whenever
> > si4713 isn't enabled.
> > 
> > This patches fixes that warning:
> > 
> > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> >  static struct si4713_platform_data rx51_si4713_platform_data = {
> > 
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> 
> a gentle reminder on this one.
> 

Let me add my

Acked-by: Arnd Bergmann <arnd@arndb.de>

You didn't say who you expect to pick up the patch. I assume Mauro
should take it because he took the patch that caused the problem,
but he might not be aware that he should look at this now.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

Hi,

On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > si4713 platform data) updated board-rx51-peripherals.c
> > > so that si4713 could be easily used on DT boot, but
> > > it ended up introducing a build warning whenever
> > > si4713 isn't enabled.
> > > 
> > > This patches fixes that warning:
> > > 
> > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > >  static struct si4713_platform_data rx51_si4713_platform_data = {
> > > 
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Cc: Tony Lindgren <tony@atomide.com>
> > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > 
> > a gentle reminder on this one.
> > 
> 
> Let me add my
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> You didn't say who you expect to pick up the patch. I assume Mauro

patch author now decides who takes the patch ? That's new :-)

> should take it because he took the patch that caused the problem,
> but he might not be aware that he should look at this now.

He is in Cc, let's ask him :-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Tony Lindgren]

* Felipe Balbi <balbi@ti.com> [141204 07:50]:
> Hi,
> 
> On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > so that si4713 could be easily used on DT boot, but
> > > > it ended up introducing a build warning whenever
> > > > si4713 isn't enabled.
> > > > 
> > > > This patches fixes that warning:
> > > > 
> > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > >  static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > 
> > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > 
> > > a gentle reminder on this one.
> > > 
> > 
> > Let me add my
> > 
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > You didn't say who you expect to pick up the patch. I assume Mauro
> 
> patch author now decides who takes the patch ? That's new :-)
> 
> > should take it because he took the patch that caused the problem,
> > but he might not be aware that he should look at this now.
> 
> He is in Cc, let's ask him :-)

Best that this one goes in along with the other si4713 patches
to avoid dependencies between trees:

Acked-by: Tony Lindgren <tony@atomide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Mauro Carvalho Chehab]

Em Thu, 04 Dec 2014 08:39:31 -0800
Tony Lindgren <tony@atomide.com> escreveu:

> * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > Hi,
> > 
> > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > so that si4713 could be easily used on DT boot, but
> > > > > it ended up introducing a build warning whenever
> > > > > si4713 isn't enabled.
> > > > > 
> > > > > This patches fixes that warning:
> > > > > 
> > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > > >  static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > > 
> > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > > 
> > > > a gentle reminder on this one.
> > > > 
> > > 
> > > Let me add my
> > > 
> > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > 
> > > You didn't say who you expect to pick up the patch. I assume Mauro
> > 
> > patch author now decides who takes the patch ? That's new :-)

Well, for patches that cross subsystem boundaries, like this one,
the best is to give a hint about whom you expect to pick it.

In this specific case, as commit 68a3c04 is in my tree, the best is
to merge the patch on it, as the patch may not even apply at Tony's
tree.

> > 
> > > should take it because he took the patch that caused the problem,
> > > but he might not be aware that he should look at this now.
> > 
> > He is in Cc, let's ask him :-)
> 
> Best that this one goes in along with the other si4713 patches
> to avoid dependencies between trees:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Thanks! I'll merge it via my tree.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 2586 bytes --]

Hi,

On Thu, Dec 04, 2014 at 03:00:12PM -0200, Mauro Carvalho Chehab wrote:
> Em Thu, 04 Dec 2014 08:39:31 -0800
> Tony Lindgren <tony@atomide.com> escreveu:
> 
> > * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > > Hi,
> > > 
> > > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > > so that si4713 could be easily used on DT boot, but
> > > > > > it ended up introducing a build warning whenever
> > > > > > si4713 isn't enabled.
> > > > > > 
> > > > > > This patches fixes that warning:
> > > > > > 
> > > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > > 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > > > >  static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > > > 
> > > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > > > 
> > > > > a gentle reminder on this one.
> > > > > 
> > > > 
> > > > Let me add my
> > > > 
> > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > > 
> > > > You didn't say who you expect to pick up the patch. I assume Mauro
> > > 
> > > patch author now decides who takes the patch ? That's new :-)
> 
> Well, for patches that cross subsystem boundaries, like this one,
> the best is to give a hint about whom you expect to pick it.
> 
> In this specific case, as commit 68a3c04 is in my tree, the best is
> to merge the patch on it, as the patch may not even apply at Tony's
> tree.

pointing to the commit that caused the problem really isn't enough ? The
commit short description (which is also on my commit log) clearly
mentions "[media]".

Anyway, I'll do that next time.

> > > > should take it because he took the patch that caused the problem,
> > > > but he might not be aware that he should look at this now.
> > > 
> > > He is in Cc, let's ask him :-)
> > 
> > Best that this one goes in along with the other si4713 patches
> > to avoid dependencies between trees:
> > 
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Thanks! I'll merge it via my tree.

tks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning

[Mauro Carvalho Chehab]

Em Thu, 04 Dec 2014 11:03:53 -0600
Felipe Balbi <balbi@ti.com> escreveu:

> Hi,
> 
> On Thu, Dec 04, 2014 at 03:00:12PM -0200, Mauro Carvalho Chehab wrote:
> > Em Thu, 04 Dec 2014 08:39:31 -0800
> > Tony Lindgren <tony@atomide.com> escreveu:
> > 
> > > * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > > > Hi,
> > > > 
> > > > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > > > so that si4713 could be easily used on DT boot, but
> > > > > > > it ended up introducing a build warning whenever
> > > > > > > si4713 isn't enabled.
> > > > > > > 
> > > > > > > This patches fixes that warning:
> > > > > > > 
> > > > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > > > 	‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > > > > >  static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > > > > 
> > > > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > > > > 
> > > > > > a gentle reminder on this one.
> > > > > > 
> > > > > 
> > > > > Let me add my
> > > > > 
> > > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > > > 
> > > > > You didn't say who you expect to pick up the patch. I assume Mauro
> > > > 
> > > > patch author now decides who takes the patch ? That's new :-)
> > 
> > Well, for patches that cross subsystem boundaries, like this one,
> > the best is to give a hint about whom you expect to pick it.
> > 
> > In this specific case, as commit 68a3c04 is in my tree, the best is
> > to merge the patch on it, as the patch may not even apply at Tony's
> > tree.
> 
> pointing to the commit that caused the problem really isn't enough ? The
> commit short description (which is also on my commit log) clearly
> mentions "[media]".
> 
> Anyway, I'll do that next time.

Ah, and please c/c linux-media ML next time, as I use patchwork there
to track patches for the media tree.

Thanks,
Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html