From: Roger Quadros <rogerq@ti.com>
To: Tony Lindgren <tony@atomide.com>,
Dmitry Lifshitz <lifshitz@compulab.co.il>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, grinberg@compulab.co.il
Subject: Re: [PATCH v2] ARM: dts: cm-t3x: add NAND support
Date: Thu, 8 Jan 2015 12:30:23 +0200 [thread overview]
Message-ID: <54AE5C3F.7010306@ti.com> (raw)
In-Reply-To: <20150108001648.GQ13010@atomide.com>
On 08/01/15 02:16, Tony Lindgren wrote:
> * Dmitry Lifshitz <lifshitz@compulab.co.il> [141229 23:42]:
>> On 12/29/2014 03:06 PM, Roger Quadros wrote:
>>> On 28/12/14 16:30, Dmitry Lifshitz wrote:
>>>> --- a/arch/arm/boot/dts/omap3-cm-t3x30.dtsi
>>>> +++ b/arch/arm/boot/dts/omap3-cm-t3x30.dtsi
>>>> @@ -50,7 +50,8 @@
>>>> #include "omap-gpmc-smsc911x.dtsi"
>>>>
>>>> &gpmc {
>>>> - ranges = <5 0 0x2c000000 0x01000000>;
>>>> + ranges = <5 0 0x2c000000 0x01000000>, /* CM-T3x30 SMSC9x Eth */
>>>> + <0 0 0x00000000 0x01000000>; /* CM-T3x NAND */
>>>
>>> Isn't this ranges property redundant as it will anyways be overridden by the board specific dts?
>>>
>>
>> The ranges are specified here (and other files below) by design.
>>
>> We built a tree like structure to organize DT files -
>> d234e4239 "ARM: dts: sbc-t3x: refactor DT support"
>>
>> It allows to inherit/override properties common for different boards.
>>
>> Our customers do not have to deal with a correct GPMC ranges settings, once
>> they base on omap3-cm-t3x.dts core module DT file (in case they do not
>> connect additional device to the bus).
>>
>> This is the point of Igor's comment to the previous patch version.
>
> Roger, do you still have pending issues with this patch?
Sorry missed this one. Thanks for the explanations Dmitry.
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
next prev parent reply other threads:[~2015-01-08 10:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 13:15 [PATCH] ARM: dts: cm-t3x: add NAND support Dmitry Lifshitz
2014-12-28 13:55 ` Igor Grinberg
2014-12-28 14:30 ` [PATCH v2] " Dmitry Lifshitz
2014-12-28 14:54 ` Igor Grinberg
2014-12-29 13:06 ` Roger Quadros
2014-12-30 7:39 ` Dmitry Lifshitz
2015-01-08 0:16 ` Tony Lindgren
2015-01-08 10:30 ` Roger Quadros [this message]
2015-01-13 16:01 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AE5C3F.7010306@ti.com \
--to=rogerq@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=grinberg@compulab.co.il \
--cc=lifshitz@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).