Re: [PATCHv3 04/35] ARM: OMAP3+: PRM: add common APIs for prm_vp_check/clear_txdone

[Tero Kristo <t-kristo@ti.com>]

On 02/25/2015 09:09 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Feb 25, 2015 at 09:04:14PM +0200, Tero Kristo wrote:
>> diff --git a/arch/arm/mach-omap2/prm_common.c b/arch/arm/mach-omap2/prm_common.c
>> index 2c2e7ed..79cee11 100644
>> --- a/arch/arm/mach-omap2/prm_common.c
>> +++ b/arch/arm/mach-omap2/prm_common.c
>> @@ -555,6 +555,40 @@ int omap_prm_clear_mod_irqs(s16 module, u8 regs, u32 wkst_mask)
>>   }
>>
>>   /**
>> + * omap_prm_vp_check_txdone - check voltage processor TX done status
>> + *
>> + * Checks if voltage processor transmission has been completed.
>> + * Returns non-zero if a transmission has completed, 0 otherwise.
>> + */
>> +u32 omap_prm_vp_check_txdone(u8 vp_id)
>> +{
>> +	if (!prm_ll_data->vp_check_txdone) {
>> +		WARN_ONCE(1, "prm: %s: no mapping function defined\n",
>> +			  __func__);
>
> same here:
>
> 	if (WARN_ONCE(!prm_ll_data->vp_check_txdone,
> 		"prm: %s: no mapping function defined\n", __func__))
>
> same for all others below
>

Similar convention (the one I used) is already used all over the place 
in the same file, would probably be better to convert them all at the 
same time if needed.

-Tero