From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Robert Abel <rabel@cit-ec.uni-bielefeld.de>
Cc: balbi@ti.com, Roger Quadros <rogerq@ti.com>,
linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
linux@arm.linux.org.uk
Subject: Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS
Date: Fri, 27 Feb 2015 17:23:40 +0300 [thread overview]
Message-ID: <54F07DEC.8000802@cogentembedded.com> (raw)
In-Reply-To: <CAMdRc4GO=FyELKkPgkL5W77MBh+CHWJ7GbEJdWU2LONLMrLTCA@mail.gmail.com>
Hello.
On 2/27/2015 5:17 PM, Robert Abel wrote:
>> Documentation/kernel-doc-nano-HOWTO.txt requires colons after the
>> parameter names, doesn't it?
> Jesus Christ, you guys are killing me...
> I've already spent way more time on this patch series than I intended
> to anyway...
That's what you get when pushing your stuff upstream. You're not alone
here. :-)
>>> + mask = (1 << nr_bits) - 1;
>> BIT(nr_bits) - 1, perhaps?
> Not happening... BIT macro obscures what's actually going on.
I did search for a macro that does ((1 << n) - 1) but didn't found it,
unfortunately...
> Regards,
> Robert
WBR, Sergei
next prev parent reply other threads:[~2015-02-27 14:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 14:45 [PATCH 0/8] ARM OMAP2+ GPMC: fixes and bus children Robert ABEL
2015-02-26 14:45 ` [PATCH 1/8] ARM OMAP2+ GPMC: don't undef DEBUG Robert ABEL
2015-02-26 14:45 ` [PATCH 2/8] ARM OMAP2+ GPMC: add bus children Robert ABEL
2015-02-27 10:24 ` Roger Quadros
2015-02-27 15:08 ` Robert Abel
2015-03-03 10:09 ` Roger Quadros
2015-03-03 10:43 ` Robert Abel
2015-02-26 14:45 ` [PATCH 4/8] ARM OMAP2+ GPMC: fix debug output alignment Robert ABEL
2015-02-26 14:45 ` [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS Robert ABEL
2015-02-26 15:06 ` Sergei Shtylyov
2015-02-27 14:17 ` Robert Abel
2015-02-27 14:23 ` Sergei Shtylyov [this message]
2015-02-27 15:51 ` Tony Lindgren
2015-02-27 10:43 ` Roger Quadros
2015-02-27 14:05 ` Robert Abel
2015-02-26 14:45 ` [PATCH 5/8] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER Robert ABEL
2015-02-26 14:45 ` [PATCH 6/8] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME Robert ABEL
2015-02-26 14:45 ` [PATCH 7/8] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug Robert ABEL
2015-02-26 14:45 ` [PATCH 8/8] ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters Robert ABEL
2015-03-03 12:53 ` [PATCH 0/8] ARM OMAP2+ GPMC: fixes and bus children Roger Quadros
2015-03-03 12:55 ` Roger Quadros
2015-03-03 12:59 ` Robert Abel
2015-03-06 0:59 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F07DEC.8000802@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rabel@cit-ec.uni-bielefeld.de \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).