linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
To: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
	dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC][PATCH 8/9] usb: otg-fsm: Remove unused members in struct otg_fsm
Date: Thu, 19 Mar 2015 12:20:47 +0200	[thread overview]
Message-ID: <550AA2FF.8080800@ti.com> (raw)
In-Reply-To: <20150319034620.GB7779@shlinux2>

On 19/03/15 05:46, Peter Chen wrote:
> On Wed, Mar 18, 2015 at 03:56:02PM +0200, Roger Quadros wrote:
>> These members are not used anywhere so remove them.
>>
>> Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
>> ---
>>  include/linux/usb/otg-fsm.h | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/include/linux/usb/otg-fsm.h b/include/linux/usb/otg-fsm.h
>> index b6ba1bf..176c4fc 100644
>> --- a/include/linux/usb/otg-fsm.h
>> +++ b/include/linux/usb/otg-fsm.h
>> @@ -95,11 +95,6 @@ struct otg_fsm {
>>  	int b_hnp_enable;
>>  	int a_clr_err;
>>  
>> -	/* Informative variables */
>> -	int a_bus_drop_inf;
>> -	int a_bus_req_inf;
>> -	int a_clr_err_inf;
>> -	int b_bus_req_inf;
>>  	/* Auxilary informative variables */
>>  	int a_suspend_req_inf;
>>  
> 
> But the above are defined at: ch 7.4.4, On-The-Go and Embedded Host
> Supplement to the USB Revision 2.0 Specification

I can leave them there then but just add a note saying that they are
not yet used by the OTG FSM.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-03-19 10:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 13:55 [RFC][PATCH 0/9] USB: OTG Core functionality Roger Quadros
2015-03-18 13:55 ` [RFC][PATCH 1/9] usb: hcd: Introduce usb_start/stop_hcd() Roger Quadros
     [not found]   ` <1426686963-11613-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2015-03-18 19:49     ` Alan Stern
     [not found]       ` <Pine.LNX.4.44L0.1503181538170.1497-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2015-03-18 21:41         ` Tony Lindgren
2015-03-19  1:51           ` Alan Stern
     [not found]             ` <Pine.LNX.4.44L0.1503182147410.32267-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2015-03-19  2:38               ` Tony Lindgren
2015-03-19 11:38       ` Roger Quadros
2015-03-19 14:17         ` Alan Stern
     [not found]         ` <550AB538.7090806-l0cyMroinI0@public.gmane.org>
2015-03-20  6:32           ` Peter Chen
2015-03-20  9:49             ` Roger Quadros
2015-03-19  1:46   ` Peter Chen
2015-03-18 13:55 ` [RFC][PATCH 2/9] usb: gadget: add usb_gadget_start/stop() Roger Quadros
     [not found]   ` <1426686963-11613-3-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2015-03-19  3:30     ` Peter Chen
2015-03-19 10:14       ` Roger Quadros
     [not found]         ` <550AA18F.2000106-l0cyMroinI0@public.gmane.org>
2015-03-19 14:09           ` Li Jun
     [not found]             ` <20150319140859.GA7950-KgLukfWpBlCctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2015-03-19 14:50               ` Roger Quadros
2015-03-20  7:18                 ` Peter Chen
2015-03-20  9:46                   ` Roger Quadros
2015-03-20 11:08                     ` Roger Quadros
     [not found]                       ` <550BFFA9.7050400-l0cyMroinI0@public.gmane.org>
2015-03-21  1:30                         ` Peter Chen
2015-03-18 13:55 ` [RFC][PATCH 3/9] usb: otg: add OTG core Roger Quadros
2015-03-19  3:40   ` Peter Chen
2015-03-19 10:18     ` Roger Quadros
2015-03-20  7:45       ` Peter Chen
2015-03-20  9:18         ` Roger Quadros
2015-03-20  9:32           ` Peter Chen
     [not found]   ` <1426686963-11613-4-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2015-03-19  8:26     ` Li Jun
2015-03-19 10:30       ` Roger Quadros
     [not found]         ` <550AA556.1030301-l0cyMroinI0@public.gmane.org>
2015-03-19 14:41           ` Li Jun
2015-03-19 14:54             ` Roger Quadros
2015-03-18 13:55 ` [RFC][PATCH 4/9] usb: otg: hub: Notify OTG fsm when A device sets b_hnp_enable Roger Quadros
2015-03-18 13:55 ` [RFC][PATCH 5/9] usb: hcd: adapt to OTG Roger Quadros
2015-03-18 13:56 ` [RFC][PATCH 6/9] usb: gadget: udc: " Roger Quadros
2015-03-18 13:56 ` [RFC][PATCH 7/9] usb: dwc3: adapt to OTG core Roger Quadros
2015-03-18 13:56 ` [RFC][PATCH 8/9] usb: otg-fsm: Remove unused members in struct otg_fsm Roger Quadros
2015-03-19  3:46   ` Peter Chen
2015-03-19 10:20     ` Roger Quadros [this message]
2015-03-18 13:56 ` [RFC][PATCH 9/9] usb: otg-fsm: Add documentation for " Roger Quadros
2015-03-18 17:37 ` [RFC][PATCH 0/9] USB: OTG Core functionality Tony Lindgren
     [not found]   ` <20150318173726.GS31346-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-03-19 10:31     ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550AA2FF.8080800@ti.com \
    --to=rogerq-l0cymroini0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).