Hi, Tony This patch brakes the apollon board. apollon (omap2420) use IRQF_TRIGGER_RISING which means IRQF_TRIGGER_HIGH. so we add it as below #define SMC_IRQ_FLAGS (machine_is_omap_apollon() ? IRQF_TRIGGER_HIGH : IRQF_TRIGGER_LOW) please add this one I tested it. Thank you, Kyungmin Park ------- Original Message ------- Sender : Tony Lindgren Date : Nov 16, 2006 09:32 Title : Re: [PATCH] H4 / 2430SDP ethernet IRQ flags fix * Syed Mohammed, Khasim [061116 01:36]: > Hi Tony, > > +#ifdef CONFIG_ARCH_OMAP1 > +#define SMC_IRQ_FLAGS (machine_is_omap_innovator() ? > IRQF_TRIGGER_RISING : \ > + IRQF_TRIGGER_FALLING) > +#else > +#define SMC_IRQ_FLAGS IRQF_TRIGGER_LOW > +#endif > > This looks fine to me, please push this one.