From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
balbi@ti.com, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: nsekhar@ti.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH 4/5] usb: dwc3: ep0: Add chained TRB support
Date: Wed, 10 Jun 2015 21:11:14 +0300 [thread overview]
Message-ID: <55787DC2.7030703@cogentembedded.com> (raw)
In-Reply-To: <1433927932-32395-5-git-send-email-kishon@ti.com>
Hello.
On 06/10/2015 12:18 PM, Kishon Vijay Abraham I wrote:
> Add chained TRB support to ep0. Now TRB's can be chained just by
> invoking _dwc3_ep0_start_trans_ with 'chain' parameter set to true.
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/usb/dwc3/ep0.c | 16 +++++++++++++---
> drivers/usb/dwc3/gadget.c | 2 +-
> 2 files changed, 14 insertions(+), 4 deletions(-)
> diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
> index d1a2be1..6847afe 100644
> --- a/drivers/usb/dwc3/ep0.c
> +++ b/drivers/usb/dwc3/ep0.c
[...]
> @@ -78,10 +81,17 @@ static int dwc3_ep0_start_trans(struct dwc3 *dwc, u8 epnum, dma_addr_t buf_dma,
> trb->ctrl = type;
>
> trb->ctrl |= (DWC3_TRB_CTRL_HWO
> - | DWC3_TRB_CTRL_LST
> - | DWC3_TRB_CTRL_IOC
> | DWC3_TRB_CTRL_ISP_IMI);
>
> + if (chain)
> + trb->ctrl |= DWC3_TRB_CTRL_CHN;
> + else
> + trb->ctrl |= (DWC3_TRB_CTRL_IOC
> + | DWC3_TRB_CTRL_LST);
Parens not needed here (and above too).
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-06-10 18:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 9:18 [PATCH 0/5] usb: dwc3: handle non maxpacket aligned transfers > 512 Kishon Vijay Abraham I
[not found] ` <1433927932-32395-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-06-10 9:18 ` [PATCH 1/5] usb: dwc3: ep0: use _roundup_ to calculate the transfer size Kishon Vijay Abraham I
2015-07-06 19:00 ` Felipe Balbi
2015-07-10 14:59 ` Kishon Vijay Abraham I
2015-06-10 9:18 ` [PATCH 2/5] usb: dwc3: ep0: preparation for handling non maxpacket aligned transfers > 512 Kishon Vijay Abraham I
2015-06-10 18:16 ` Sergei Shtylyov
2015-06-10 9:18 ` [PATCH 3/5] usb: dwc3; ep0: Modify _dwc3_ep0_start_trans_ API to take 'chain' parameter Kishon Vijay Abraham I
2015-06-10 18:12 ` Sergei Shtylyov
2015-06-10 9:18 ` [PATCH 4/5] usb: dwc3: ep0: Add chained TRB support Kishon Vijay Abraham I
2015-06-10 18:11 ` Sergei Shtylyov [this message]
2015-06-10 9:18 ` [PATCH 5/5] usb: dwc3: ep0: handle non maxpacket aligned transfers > 512 Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55787DC2.7030703@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).