* Re: [PATCH 1/1] add pwm capability to dm816x [not found] <CAFZh4h8ikia8oKsZ6B12QZ1HdTV8Teu-+U9x_Ydu_-uOyh7-HA@mail.gmail.com> @ 2015-06-15 19:32 ` Tero Kristo 2015-06-16 20:56 ` Suman Anna 2015-07-16 6:07 ` Paul Walmsley 1 sibling, 1 reply; 3+ messages in thread From: Tero Kristo @ 2015-06-15 19:32 UTC (permalink / raw) To: Brian Hutchinson, mturquette, sboyd Cc: linux-kernel, linux-omap, paul, Tony Lindgren On 06/15/2015 09:36 PM, Brian Hutchinson wrote: > Clocks 4-7 are capable of PWM output on dm816x. > > This adds the pwm capability to those timers. Use checkpatch pls, I see lots of whitespace errors. Also, I don't think Mike / Stephen care about this patch, as it is against omap hwmod data only. -Tero > > Cc: Paul Walmsley <paul@pwsan.com <mailto:paul@pwsan.com>> > Cc: Tero Kristo <t-kristo@ti.com <mailto:t-kristo@ti.com>> > Cc: Tony Lindgren <tony@atomide.com <mailto:tony@atomide.com>> > Signed-off-by: Brian Hutchinson <b.hutchman@gmail.com > <mailto:b.hutchman@gmail.com><mailto:tony@atomide.com>> > > --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c_orig 2015-06-15 > 13:20:43.174343431 -0400 > +++ arch/arm/mach-omap2/omap_hwmod_81xx_data.c 2015-06-15 > 13:34:51.770551392 -0400 > @@ -546,6 +546,14 @@ static struct omap_timer_capability_dev_ > .timer_capability = OMAP_TIMER_ALWON, > }; > > +/* pwm timers dev attribute. > + * timers 4-7 may be used for PWM output - see datasheet timer terminal > + * functions table > + */ > +static struct omap_timer_capability_dev_attr capability_pwm_dev_attr = { > + .timer_capability = OMAP_TIMER_ALWON | OMAP_TIMER_HAS_PWM, > +}; > + > static struct omap_hwmod dm816x_timer1_hwmod = { > .name = "timer1", > .clkdm_name = "alwon_l3s_clkdm", > @@ -619,7 +627,7 @@ static struct omap_hwmod dm816x_timer4_h > .modulemode = MODULEMODE_SWCTRL, > }, > }, > - .dev_attr = &capability_alwon_dev_attr, > + .dev_attr = &capability_pwm_dev_attr, > .class = &dm816x_timer_hwmod_class, > }; > > @@ -640,7 +648,7 @@ static struct omap_hwmod dm816x_timer5_h > .modulemode = MODULEMODE_SWCTRL, > }, > }, > - .dev_attr = &capability_alwon_dev_attr, > + .dev_attr = &capability_pwm_dev_attr, > .class = &dm816x_timer_hwmod_class, > }; > > @@ -661,7 +669,7 @@ static struct omap_hwmod dm816x_timer6_h > .modulemode = MODULEMODE_SWCTRL, > }, > }, > - .dev_attr = &capability_alwon_dev_attr, > + .dev_attr = &capability_pwm_dev_attr, > .class = &dm816x_timer_hwmod_class, > }; > > @@ -682,7 +690,7 @@ static struct omap_hwmod dm816x_timer7_h > .modulemode = MODULEMODE_SWCTRL, > }, > }, > - .dev_attr = &capability_alwon_dev_attr, > + .dev_attr = &capability_pwm_dev_attr, > .class = &dm816x_timer_hwmod_class, > }; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] add pwm capability to dm816x 2015-06-15 19:32 ` [PATCH 1/1] add pwm capability to dm816x Tero Kristo @ 2015-06-16 20:56 ` Suman Anna 0 siblings, 0 replies; 3+ messages in thread From: Suman Anna @ 2015-06-16 20:56 UTC (permalink / raw) To: Kristo, Tero, Brian Hutchinson, mturquette@linaro.org, sboyd@codeaurora.org Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, paul@pwsan.com, Tony Lindgren Brian, On 06/15/2015 02:32 PM, Kristo, Tero wrote: > On 06/15/2015 09:36 PM, Brian Hutchinson wrote: >> Clocks 4-7 are capable of PWM output on dm816x. >> >> This adds the pwm capability to those timers. > > Use checkpatch pls, I see lots of whitespace errors. > > Also, I don't think Mike / Stephen care about this patch, as it is > against omap hwmod data only. The capabilities should be added to the DT nodes, not to the hwmods. The hwmod timer capabilities are needed only for non-DT SoCs, and dm816x is DT boot only. regards Suman > > -Tero > >> >> Cc: Paul Walmsley <paul@pwsan.com <mailto:paul@pwsan.com>> >> Cc: Tero Kristo <t-kristo@ti.com <mailto:t-kristo@ti.com>> >> Cc: Tony Lindgren <tony@atomide.com <mailto:tony@atomide.com>> >> Signed-off-by: Brian Hutchinson <b.hutchman@gmail.com >> <mailto:b.hutchman@gmail.com><mailto:tony@atomide.com>> >> >> --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c_orig 2015-06-15 >> 13:20:43.174343431 -0400 >> +++ arch/arm/mach-omap2/omap_hwmod_81xx_data.c 2015-06-15 >> 13:34:51.770551392 -0400 >> @@ -546,6 +546,14 @@ static struct omap_timer_capability_dev_ >> .timer_capability = OMAP_TIMER_ALWON, >> }; >> >> +/* pwm timers dev attribute. >> + * timers 4-7 may be used for PWM output - see datasheet timer terminal >> + * functions table >> + */ >> +static struct omap_timer_capability_dev_attr capability_pwm_dev_attr = { >> + .timer_capability = OMAP_TIMER_ALWON | OMAP_TIMER_HAS_PWM, >> +}; >> + >> static struct omap_hwmod dm816x_timer1_hwmod = { >> .name = "timer1", >> .clkdm_name = "alwon_l3s_clkdm", >> @@ -619,7 +627,7 @@ static struct omap_hwmod dm816x_timer4_h >> .modulemode = MODULEMODE_SWCTRL, >> }, >> }, >> - .dev_attr = &capability_alwon_dev_attr, >> + .dev_attr = &capability_pwm_dev_attr, >> .class = &dm816x_timer_hwmod_class, >> }; >> >> @@ -640,7 +648,7 @@ static struct omap_hwmod dm816x_timer5_h >> .modulemode = MODULEMODE_SWCTRL, >> }, >> }, >> - .dev_attr = &capability_alwon_dev_attr, >> + .dev_attr = &capability_pwm_dev_attr, >> .class = &dm816x_timer_hwmod_class, >> }; >> >> @@ -661,7 +669,7 @@ static struct omap_hwmod dm816x_timer6_h >> .modulemode = MODULEMODE_SWCTRL, >> }, >> }, >> - .dev_attr = &capability_alwon_dev_attr, >> + .dev_attr = &capability_pwm_dev_attr, >> .class = &dm816x_timer_hwmod_class, >> }; >> >> @@ -682,7 +690,7 @@ static struct omap_hwmod dm816x_timer7_h >> .modulemode = MODULEMODE_SWCTRL, >> }, >> }, >> - .dev_attr = &capability_alwon_dev_attr, >> + .dev_attr = &capability_pwm_dev_attr, >> .class = &dm816x_timer_hwmod_class, >> }; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] add pwm capability to dm816x [not found] <CAFZh4h8ikia8oKsZ6B12QZ1HdTV8Teu-+U9x_Ydu_-uOyh7-HA@mail.gmail.com> 2015-06-15 19:32 ` [PATCH 1/1] add pwm capability to dm816x Tero Kristo @ 2015-07-16 6:07 ` Paul Walmsley 1 sibling, 0 replies; 3+ messages in thread From: Paul Walmsley @ 2015-07-16 6:07 UTC (permalink / raw) To: Brian Hutchinson Cc: mturquette, sboyd, linux-kernel, linux-omap, Tero Kristo, Tony Lindgren Hello Brian, On Mon, 15 Jun 2015, Brian Hutchinson wrote: > Clocks 4-7 are capable of PWM output on dm816x. > > This adds the pwm capability to those timers. > > Cc: Paul Walmsley <paul@pwsan.com> > Cc: Tero Kristo <t-kristo@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > Signed-off-by: Brian Hutchinson <b.hutchman@gmail.com <tony@atomide.com>> This patch seems to be corrupted. The above line doesn't look right; there are some spurious newlines in the patch header, and tabs seem to have been converted to whitespace. Some of these issues may be due to mailer problems. Could you please fix and try again? - Paul > > --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c_orig 2015-06-15 > 13:20:43.174343431 -0400 > +++ arch/arm/mach-omap2/omap_hwmod_81xx_data.c 2015-06-15 > 13:34:51.770551392 -0400 > @@ -546,6 +546,14 @@ static struct omap_timer_capability_dev_ > .timer_capability = OMAP_TIMER_ALWON, > }; > > +/* pwm timers dev attribute. > + * timers 4-7 may be used for PWM output - see datasheet timer terminal > + * functions table > + */ > +static struct omap_timer_capability_dev_attr capability_pwm_dev_attr = { > + .timer_capability = OMAP_TIMER_ALWON | OMAP_TIMER_HAS_PWM, > +}; > + > static struct omap_hwmod dm816x_timer1_hwmod = { > .name = "timer1", > .clkdm_name = "alwon_l3s_clkdm", > @@ -619,7 +627,7 @@ static struct omap_hwmod dm816x_timer4_h > .modulemode = MODULEMODE_SWCTRL, > }, > }, > - .dev_attr = &capability_alwon_dev_attr, > + .dev_attr = &capability_pwm_dev_attr, > .class = &dm816x_timer_hwmod_class, > }; > > @@ -640,7 +648,7 @@ static struct omap_hwmod dm816x_timer5_h > .modulemode = MODULEMODE_SWCTRL, > }, > }, > - .dev_attr = &capability_alwon_dev_attr, > + .dev_attr = &capability_pwm_dev_attr, > .class = &dm816x_timer_hwmod_class, > }; > > @@ -661,7 +669,7 @@ static struct omap_hwmod dm816x_timer6_h > .modulemode = MODULEMODE_SWCTRL, > }, > }, > - .dev_attr = &capability_alwon_dev_attr, > + .dev_attr = &capability_pwm_dev_attr, > .class = &dm816x_timer_hwmod_class, > }; > > @@ -682,7 +690,7 @@ static struct omap_hwmod dm816x_timer7_h > .modulemode = MODULEMODE_SWCTRL, > }, > }, > - .dev_attr = &capability_alwon_dev_attr, > + .dev_attr = &capability_pwm_dev_attr, > .class = &dm816x_timer_hwmod_class, > }; > - Paul ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-16 6:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAFZh4h8ikia8oKsZ6B12QZ1HdTV8Teu-+U9x_Ydu_-uOyh7-HA@mail.gmail.com>
2015-06-15 19:32 ` [PATCH 1/1] add pwm capability to dm816x Tero Kristo
2015-06-16 20:56 ` Suman Anna
2015-07-16 6:07 ` Paul Walmsley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).