From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH V2 0/5] drivers/rtc/rtc-ds1307.c: Basic cleanups and support for wakeupirq Date: Wed, 24 Jun 2015 18:37:28 +0300 Message-ID: <558ACEB8.2020406@ti.com> References: <1435076114-12416-1-git-send-email-nm@ti.com> <20150624143432.GE21232@saruman.tx.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150624143432.GE21232@saruman.tx.rr.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: balbi@ti.com, Nishanth Menon Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Alexandre Belloni , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 06/24/2015 05:34 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jun 23, 2015 at 11:15:09AM -0500, Nishanth Menon wrote: >> Hi, >> >> Here is the revamp of the patch posted eariler to support wakeupirq. >> This series does a few cleanups as well prior to introducing the >> generic apis required to support the wakeirq mechanism used on certain >> TI SoCs. Cleanups done here are just minimal set of the cleanups we >> discussed in [2]. >> >> Series is based on next-20150623 >> >> Test log: http://pastebin.ubuntu.com/11763002/ >> >> NOTE1: I have only tested in mcp79410 device, and not on other >> ds1307-rtc driver compatbile devices as I dont have any other. >> additional testing might be nice to have. >> NOTE2: there are additional fixes that linux-next seems to need but >> those are in omap-rtc, cpufreq etc, but those are not related by the >> ds-1307. >> >> V1: https://patchwork.kernel.org/patch/4759171/ >> >> NOTE: Patch 5/5 of the series is meant to indicate the usage, and will >> be reposted along with other wakeup sources to be enabled once the >> driver changes are accepted. >> >> Felipe Balbi (1): >> drivers/rtc/rtc-ds1307.c: Convert to threaded IRQ >> >> Nishanth Menon (4): >> drivers/rtc/rtc-ds1307.c: Switch to managed irq allocation >> drivers/rtc/rtc-ds1307.c: Sort the headers >> drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source > > for the series, except the patch which I wrote : > > Acked-by: Felipe Balbi > With minor comment to patch 4: Reviewed-by: Grygorii Strashko -- regards, -grygorii