* [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ
@ 2015-07-06 15:11 Grygorii Strashko
2015-07-06 15:25 ` Tony Lindgren
2015-07-16 12:36 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Grygorii Strashko @ 2015-07-06 15:11 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-omap, linux-gpio, linux-kernel, Grygorii Strashko,
Nishanth Menon, Tony Lindgren
On DRA7 there is one pinctrl domain (dra7_pmx_core) and
PRCM wake-up IRQ is not shared, so remove quirk.
Cc: Nishanth Menon <nm@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/pinctrl/pinctrl-single.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 0b8d480..9b24b343 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
};
static const struct pcs_soc_data pinctrl_single_dra7 = {
- .flags = PCS_QUIRK_SHARED_IRQ,
.irq_enable_mask = (1 << 24), /* WAKEUPENABLE */
.irq_status_mask = (1 << 25), /* WAKEUPEVENT */
};
--
2.4.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ
2015-07-06 15:11 [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ Grygorii Strashko
@ 2015-07-06 15:25 ` Tony Lindgren
2015-07-07 7:23 ` Tero Kristo
2015-07-16 12:36 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2015-07-06 15:25 UTC (permalink / raw)
To: Grygorii Strashko, Tero Kristo
Cc: Linus Walleij, linux-omap, linux-gpio, linux-kernel,
Nishanth Menon
* Grygorii Strashko <grygorii.strashko@ti.com> [150706 08:14]:
> On DRA7 there is one pinctrl domain (dra7_pmx_core) and
> PRCM wake-up IRQ is not shared, so remove quirk.
>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/pinctrl/pinctrl-single.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index 0b8d480..9b24b343 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
> };
>
> static const struct pcs_soc_data pinctrl_single_dra7 = {
> - .flags = PCS_QUIRK_SHARED_IRQ,
> .irq_enable_mask = (1 << 24), /* WAKEUPENABLE */
> .irq_status_mask = (1 << 25), /* WAKEUPEVENT */
> };
Tero, care to take a look at this one and ack if OK?
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ
2015-07-06 15:25 ` Tony Lindgren
@ 2015-07-07 7:23 ` Tero Kristo
2015-07-07 7:43 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Tero Kristo @ 2015-07-07 7:23 UTC (permalink / raw)
To: Tony Lindgren, Grygorii Strashko
Cc: Linus Walleij, linux-omap, linux-gpio, linux-kernel,
Nishanth Menon
On 07/06/2015 06:25 PM, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [150706 08:14]:
>> On DRA7 there is one pinctrl domain (dra7_pmx_core) and
>> PRCM wake-up IRQ is not shared, so remove quirk.
>>
>> Cc: Nishanth Menon <nm@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> drivers/pinctrl/pinctrl-single.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
>> index 0b8d480..9b24b343 100644
>> --- a/drivers/pinctrl/pinctrl-single.c
>> +++ b/drivers/pinctrl/pinctrl-single.c
>> @@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
>> };
>>
>> static const struct pcs_soc_data pinctrl_single_dra7 = {
>> - .flags = PCS_QUIRK_SHARED_IRQ,
>> .irq_enable_mask = (1 << 24), /* WAKEUPENABLE */
>> .irq_status_mask = (1 << 25), /* WAKEUPEVENT */
>> };
>
> Tero, care to take a look at this one and ack if OK?
Looks fine to me.
Acked-by: Tero Kristo <t-kristo@ti.com>
>
> Regards,
>
> Tony
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ
2015-07-07 7:23 ` Tero Kristo
@ 2015-07-07 7:43 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2015-07-07 7:43 UTC (permalink / raw)
To: Tero Kristo
Cc: Grygorii Strashko, Linus Walleij, linux-omap, linux-gpio,
linux-kernel, Nishanth Menon
* Tero Kristo <t-kristo@ti.com> [150707 00:25]:
> On 07/06/2015 06:25 PM, Tony Lindgren wrote:
> >* Grygorii Strashko <grygorii.strashko@ti.com> [150706 08:14]:
> >>On DRA7 there is one pinctrl domain (dra7_pmx_core) and
> >>PRCM wake-up IRQ is not shared, so remove quirk.
> >>
> >>Cc: Nishanth Menon <nm@ti.com>
> >>Cc: Tony Lindgren <tony@atomide.com>
> >>Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
> >>Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> >>---
> >> drivers/pinctrl/pinctrl-single.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >>diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> >>index 0b8d480..9b24b343 100644
> >>--- a/drivers/pinctrl/pinctrl-single.c
> >>+++ b/drivers/pinctrl/pinctrl-single.c
> >>@@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
> >> };
> >>
> >> static const struct pcs_soc_data pinctrl_single_dra7 = {
> >>- .flags = PCS_QUIRK_SHARED_IRQ,
> >> .irq_enable_mask = (1 << 24), /* WAKEUPENABLE */
> >> .irq_status_mask = (1 << 25), /* WAKEUPEVENT */
> >> };
> >
> >Tero, care to take a look at this one and ack if OK?
>
> Looks fine to me.
>
> Acked-by: Tero Kristo <t-kristo@ti.com>
OK thanks for checking, so from me too:
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ
2015-07-06 15:11 [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ Grygorii Strashko
2015-07-06 15:25 ` Tony Lindgren
@ 2015-07-16 12:36 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2015-07-16 12:36 UTC (permalink / raw)
To: Grygorii Strashko
Cc: Linux-OMAP, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Nishanth Menon, Tony Lindgren
On Mon, Jul 6, 2015 at 5:11 PM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> On DRA7 there is one pinctrl domain (dra7_pmx_core) and
> PRCM wake-up IRQ is not shared, so remove quirk.
>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Patch applied with the ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-16 12:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-06 15:11 [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ Grygorii Strashko
2015-07-06 15:25 ` Tony Lindgren
2015-07-07 7:23 ` Tero Kristo
2015-07-07 7:43 ` Tony Lindgren
2015-07-16 12:36 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).