From: Keerthy <a0393675@ti.com>
To: Paul Walmsley <paul@pwsan.com>, Keerthy <j-keerthy@ti.com>
Cc: tony@atomide.com, t-kristo@ti.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, bcousson@baylibre.com,
galak@codeaurora.org, pawel.moll@arm.com
Subject: Re: [PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register
Date: Thu, 16 Jul 2015 10:46:09 +0530 [thread overview]
Message-ID: <55A73E19.3020308@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1507160153240.32764@utopia.booyaka.com>
Paul,
Thanks for the review!
On Thursday 16 July 2015 07:24 AM, Paul Walmsley wrote:
> Hi
>
> a few minor comments
>
> On Wed, 8 Jul 2015, Keerthy wrote:
>
>> PRM_IO_PMCTRL_OFFSET need not be same for all SOCs hence
>> remove hardcoding and use the value provided by the omap_prcm_irq_setup
>> structure.
>
> Please mention here that the reason why you're making this change is to
> support AM437x.
Sure. I will do that.
>
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> arch/arm/mach-omap2/prcm-common.h | 1 +
>> arch/arm/mach-omap2/prm44xx.c | 11 ++++++-----
>> 2 files changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/prcm-common.h b/arch/arm/mach-omap2/prcm-common.h
>> index 6ae0b3a..2e60406 100644
>> --- a/arch/arm/mach-omap2/prcm-common.h
>> +++ b/arch/arm/mach-omap2/prcm-common.h
>> @@ -494,6 +494,7 @@ struct omap_prcm_irq {
>> struct omap_prcm_irq_setup {
>> u16 ack;
>> u16 mask;
>> + u16 pm_ctrl;
>
> Please add a kerneldoc structure documentation line for this new field, to
> match the existing documentation here.
Okay.
>
>> u8 nr_regs;
>> u8 nr_irqs;
>> const struct omap_prcm_irq *irqs;
>> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
>> index 4541700..8149e5a 100644
>> --- a/arch/arm/mach-omap2/prm44xx.c
>> +++ b/arch/arm/mach-omap2/prm44xx.c
>> @@ -45,6 +45,7 @@ static const struct omap_prcm_irq omap4_prcm_irqs[] = {
>> static struct omap_prcm_irq_setup omap4_prcm_irq_setup = {
>> .ack = OMAP4_PRM_IRQSTATUS_MPU_OFFSET,
>> .mask = OMAP4_PRM_IRQENABLE_MPU_OFFSET,
>> + .pm_ctrl = OMAP4_PRM_IO_PMCTRL_OFFSET,
>> .nr_regs = 2,
>> .irqs = omap4_prcm_irqs,
>> .nr_irqs = ARRAY_SIZE(omap4_prcm_irqs),
>> @@ -306,10 +307,10 @@ static void omap44xx_prm_reconfigure_io_chain(void)
>> omap4_prm_rmw_inst_reg_bits(OMAP4430_WUCLK_CTRL_MASK,
>> OMAP4430_WUCLK_CTRL_MASK,
>> inst,
>> - OMAP4_PRM_IO_PMCTRL_OFFSET);
>> + omap4_prcm_irq_setup.pm_ctrl);
>> omap_test_timeout(
>> (((omap4_prm_read_inst_reg(inst,
>> - OMAP4_PRM_IO_PMCTRL_OFFSET) &
>> + omap4_prcm_irq_setup.pm_ctrl) &
>> OMAP4430_WUCLK_STATUS_MASK) >>
>> OMAP4430_WUCLK_STATUS_SHIFT) == 1),
>> MAX_IOPAD_LATCH_TIME, i);
>> @@ -319,10 +320,10 @@ static void omap44xx_prm_reconfigure_io_chain(void)
>> /* Trigger WUCLKIN disable */
>> omap4_prm_rmw_inst_reg_bits(OMAP4430_WUCLK_CTRL_MASK, 0x0,
>> inst,
>> - OMAP4_PRM_IO_PMCTRL_OFFSET);
>> + omap4_prcm_irq_setup.pm_ctrl);
>> omap_test_timeout(
>> (((omap4_prm_read_inst_reg(inst,
>> - OMAP4_PRM_IO_PMCTRL_OFFSET) &
>> + omap4_prcm_irq_setup.pm_ctrl) &
>> OMAP4430_WUCLK_STATUS_MASK) >>
>> OMAP4430_WUCLK_STATUS_SHIFT) == 0),
>> MAX_IOPAD_LATCH_TIME, i);
>> @@ -350,7 +351,7 @@ static void __init omap44xx_prm_enable_io_wakeup(void)
>> omap4_prm_rmw_inst_reg_bits(OMAP4430_GLOBAL_WUEN_MASK,
>> OMAP4430_GLOBAL_WUEN_MASK,
>> inst,
>> - OMAP4_PRM_IO_PMCTRL_OFFSET);
>> + omap4_prcm_irq_setup.pm_ctrl);
>> }
>>
>> /**
>> --
>> 1.9.1
>>
>
>
> - Paul
>
next prev parent reply other threads:[~2015-07-16 5:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 5:42 [PATCH v2 0/6] ARM: AM437x: Add IO wake up support Keerthy
2015-07-08 5:42 ` [PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register Keerthy
2015-07-16 1:54 ` Paul Walmsley
2015-07-16 5:16 ` Keerthy [this message]
2015-07-08 5:42 ` [PATCH v2 2/6] ARM: AM43xx: Add the PRM IRQ register offsets Keerthy
2015-07-16 2:33 ` Paul Walmsley
2015-07-16 2:38 ` Paul Walmsley
2015-07-16 5:16 ` Keerthy
2015-07-08 5:42 ` [PATCH v2 3/6] ARM: dts: AM4372: Add PRCM IRQ entry Keerthy
2015-07-08 5:42 ` [PATCH v2 4/6] ARM: OMAP: PRM: Remove hardcoding of IRQENABLE_MPU_2 and IRQSTATUS_MPU_2 register offsets Keerthy
2015-07-16 2:40 ` Paul Walmsley
2015-07-08 5:42 ` [PATCH v2 5/6] ARM: OMAP4+: PRM: Add AM437x specific data Keerthy
2015-07-08 5:42 ` [PATCH v2 6/6] ARM: PRM: AM437x: Enable IO wakeup feature Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A73E19.3020308@ti.com \
--to=a0393675@ti.com \
--cc=bcousson@baylibre.com \
--cc=galak@codeaurora.org \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=pawel.moll@arm.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).