From: Jyri Sarha <jsarha@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
peter.ujfalusi@ti.com, moinejf@free.fr, airlied@linux.ie,
dri-devel@lists.freedesktop.org, liam.r.girdwood@linux.intel.com,
tony@atomide.com, tomi.valkeinen@ti.com, bcousson@baylibre.com,
rmk+kernel@arm.linux.org.uk, linux-omap@vger.kernel.org
Subject: Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders
Date: Mon, 17 Aug 2015 10:57:03 +0300 [thread overview]
Message-ID: <55D193CF.5070605@ti.com> (raw)
In-Reply-To: <20150814161820.GU10748@sirena.org.uk>
Missed one commet first time around...
On 08/14/15 19:18, Mark Brown wrote:
> On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote:
...
>> +/* HDMI codec initalization data */
>> +struct hdmi_codec_pdata {
>> + struct device *dev; /* The HDMI encoder registering the codec */
>
> Shouldn't this just be dev->parent?
>
No. The HDMI encoder device is the parent for HDMI-codec.
The patch you took in in the last round uses the ASoC component drivers
parent's of-node if the component driver does not have one itself. In
this case the phandle in the binding points to the HDMI encoder's node,
which is the parent of the HDMI codec.
Best regards,
Jyri
next prev parent reply other threads:[~2015-08-17 7:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 9:30 [PATCH RFC v3 0/7] Implement generic ASoC HDMI codec and use it in tda998x Jyri Sarha
2015-08-14 9:30 ` [PATCH RFC v3 1/7] drm/edid: add function to help find SADs, DO NOT MERGE Jyri Sarha
[not found] ` <cover.1439542916.git.jsarha-l0cyMroinI0@public.gmane.org>
2015-08-14 9:30 ` [PATCH RFC v3 2/7] ASoC: hdmi: Remove obsolete dummy HDMI codec Jyri Sarha
[not found] ` <360a38c83ae2a24620da85b8496b745326d995de.1439542916.git.jsarha-l0cyMroinI0@public.gmane.org>
2015-08-14 16:10 ` Mark Brown
2015-08-17 7:00 ` Jyri Sarha
2015-08-17 18:46 ` Mark Brown
2015-08-14 9:30 ` [PATCH RFC v3 4/7] drm/i2c: tda998x: Add support of a DT graph of ports Jyri Sarha
2015-08-14 9:30 ` [PATCH RFC v3 6/7] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality Jyri Sarha
[not found] ` <1e8e3215caa932dab68de8576aee81f5e1008163.1439542916.git.jsarha-l0cyMroinI0@public.gmane.org>
2015-08-14 10:06 ` Russell King - ARM Linux
2015-08-17 7:25 ` Jyri Sarha
2015-08-14 9:30 ` [PATCH RFC v3 7/7] ARM: dts: am335x-boneblack: Add HDMI audio support Jyri Sarha
2015-08-14 9:30 ` [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders Jyri Sarha
2015-08-14 9:57 ` Russell King - ARM Linux
2015-08-17 6:50 ` Jyri Sarha
[not found] ` <ed41a6c0b594866c05e695cc066371d0e3862c7e.1439542916.git.jsarha-l0cyMroinI0@public.gmane.org>
2015-08-14 16:18 ` Mark Brown
2015-08-17 7:07 ` Jyri Sarha
2015-08-17 18:41 ` Mark Brown
2015-08-17 19:22 ` Jyri Sarha
2015-08-17 7:57 ` Jyri Sarha [this message]
2015-08-17 12:59 ` Jyri Sarha
2015-08-14 9:30 ` [PATCH RFC v3 5/7] drm/i2c: tda998x: Remove include/sound/tda998x.h and fix graph parsing Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D193CF.5070605@ti.com \
--to=jsarha@ti.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=peter.ujfalusi@ti.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).