From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield Date: Wed, 26 Aug 2015 15:07:38 +0530 Message-ID: <55DD88E2.3000401@ti.com> References: <1439568064-7907-1-git-send-email-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1439568064-7907-1-git-send-email-bigeasy@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Sebastian Andrzej Siewior , peter@hurleysoftware.com Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-serial@vger.kernel.org, john.ogness@linutronix.de, Greg Kroah-Hartman List-Id: linux-omap@vger.kernel.org On Friday 14 August 2015 09:31 PM, Sebastian Andrzej Siewior wrote: > From: John Ogness > > That bitfield is modified by read + or + write operation. If someone > sets any of the other two bits it might render the lock useless. > > While at it, remove other bitfields as well to avoid more such > errors. > > Cc: Greg Kroah-Hartman > Signed-off-by: John Ogness > Signed-off-by: Sebastian Andrzej Siewior Tested with wilink BT module on TI's DRA7 EVM. Tested-by: Sekhar Nori Thanks, Sekhar