From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF709213E89 for ; Fri, 22 May 2026 12:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779453932; cv=none; b=H7CGCXaqLzzysxBubTwohB2GZDYQ1mcZ2HHdTxQrPLBS40lpS7vNrEd0PAiLeB3HwnYvUOPj9PVyPeO9I0bnhlxenX1QjRKui5sik8fFpr8wgDAvAc1lNQFhmpPczf6fKE/jUodyV31czaOwnNMlOtBPFDFBK8lNLwjoGvOQIow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779453932; c=relaxed/simple; bh=B6Wrx8wptznPEXE7GgI4oCIpRWZlbijf1SHKh604G6I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eWShlf7r/PNNUJnARAucr86B2+cdFPVGkfMDW/GWHBz/z16c/5d86Cjs7M7ONuL6NfuZS5YyoWWM1YC176iFloLmJa1GCj31uIfFBIqkH6inbY6lJ0z7lX99at60jihtwmZwU54Ar23KFdf2CKjKNaKfUe4yaqV+sIEdrz7gmdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S9TdA1s9; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S9TdA1s9" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5aa1b2327c8so8975575e87.0 for ; Fri, 22 May 2026 05:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779453928; x=1780058728; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jEx08WhtJbuH9Jvv5ffuVG6XRuDs6AIyFWz3HRiJmYw=; b=S9TdA1s9sU06k7pAAsQhZgPt6Jm2cy1jpfHiVjy/+4+phsKTB39AbQjFrUaHHvTuHa 7xcha/kC9qOvlrvOc+x2JTP+jZxZ/e3H1ei/X60CDqJpjGmR8Nzbf9OwEeh6jXSYmMe6 1lqGhLX9WLcsDUNoRDwB8RN2/7jcZGUB/8QVzZr9eANTujcgTuVz1xsDUvY1h5CzWkhw CjjnUJzTgxZB4Xvh+ERZIfoeKsbVY7GHoFXwuSABK574IaI9xqc2uETLj3zU1ZFqV2YS GuqN5wtrNjE3MnCX7eUhhI4j839ntAaSS2DRdL1e8/Q6vQSCXDKpTqbm32FekGdEJyes Fk2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779453928; x=1780058728; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jEx08WhtJbuH9Jvv5ffuVG6XRuDs6AIyFWz3HRiJmYw=; b=Fl4oJWDMFF5ZeVdrBcYHRnBSl/kcxtG2+yY7qxj91Hb3qTNUbRn5vxpnlotzB2w8Ey JbhJyJYfFCHa3Av88vy56EBflrEQsdgUIzT8TP1t4zA9yxxWXeFmbWwQ9ZOTjRl74o2X MmJUt1z2fzmPnKqF9M+CWwO5inQqmanWYwcOBVkL1W5l45DFVmoMEYVqyM35MFaBdXlA cZ4Gt0I3LvZr8XRYKzPMo2BlNAr0+6ianHMOicEbfgrUrjKQLXEzdCd09cIGGX1VEER3 KEo3y+MfPdq9nV3jS3T2D9jlRpugUC29QlMf91wTNPc91C881Kpu0wqLXXmHHqVeBVo6 wOaQ== X-Forwarded-Encrypted: i=1; AFNElJ8n4T6Ndfo17AYCreFIvM4pcrpl+uw+sDXeS5xrayKkB5cUCdZPLj99EfMkXTHua3+qjXaunBWvYD9+@vger.kernel.org X-Gm-Message-State: AOJu0YxdmBQ4ao0N18XOBvOrJJGIX1en8SuYX8n/rF1ySXy87Ch6QHu4 4FZWbYoc+pBipaO90pe/9jg+RbYI1Hcgq/hEJUmtfsX8PJlG53TdHHbo X-Gm-Gg: Acq92OFAr5od0cNDUW+qS4ZIIJLwv3pjqXoYXVpNVxZBJEaSktvaCo/tdogkGNblCMq q+IxPj+waUKtdwDUgDvLp45SQAEdduEEIIKbiYro8Y65UStC9uP/PWpLDNXpStnvjJAELHRON4d 2mT4XFiBVrNvGZqa/UEhxzYwlVyQsd5ynlWo7NDEOthKQ4/qQMQfaWVZr0IdW1H9hrs6fwl4YKe xoplTNQV2/V7RFO78cwchAiR/qwNM656o14MgPRklvHIp9mWst/PT95HU/oIkQ3ASQ6Hj+jBs58 YEV1CMV/6sz+4nMyu2zV+yNPf8bXvdI1H2mpKR7Hrsr9jQvZ6bYnOhs6Fz2HW934onRqNPsfZlL oPIbL69t7wbQHhOY1A6yp+SOhDgLOSZxejCXJbbaFRKxFX/iaFePWQrGrgmQEFDEh5KrRhiZgZl 7gPv7MCw4oEcAjSziG2XsxW/yzsdKtIuiQ8qhsTQ/Tp980J2re3VFWzS3GJ/N7JfKMf8HX/Ecrx lkkeajw X-Received: by 2002:a05:6512:33c9:b0:5a8:64c4:38c4 with SMTP id 2adb3069b0e04-5aa32314258mr1031399e87.8.1779453927777; Fri, 22 May 2026 05:45:27 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa32cb37bfsm401018e87.11.2026.05.22.05.45.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 05:45:27 -0700 (PDT) Message-ID: <55c36da0-6cc4-4c95-88ef-3dd5b2181b0d@gmail.com> Date: Fri, 22 May 2026 15:45:25 +0300 Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] [v3] input: gpio-keys: make legacy gpiolib optional To: Arnd Bergmann , Arnd Bergmann , "open list:GPIO SUBSYSTEM" Cc: linux-kernel@vger.kernel.org, Christian Lamparter , Johannes Berg , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Thomas Bogendoerfer , John Paul Adrian Glaubitz , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Lee Jones , Pavel Machek , Florian Fainelli , Jonas Gorski , Andrew Lunn , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, Linux-OMAP , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sh@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, Netdev References: <20260520183815.2510387-1-arnd@kernel.org> <20260520183815.2510387-3-arnd@kernel.org> <681f328c-bc8a-4410-b876-f8c5f116325d@app.fastmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <681f328c-bc8a-4410-b876-f8c5f116325d@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/05/2026 11:28, Arnd Bergmann wrote: > On Fri, May 22, 2026, at 06:55, Matti Vaittinen wrote: >> On 20/05/2026 21:38, Arnd Bergmann wrote: >>> From: Arnd Bergmann >>> >>> The two Rohm PMIC drivers use a gpio-keys device without an actual GPIO, >>> passing an IRQ number instead. In order to keep this working both with >>> and with CONFIG_GPIOLIB_LEGACY, change the gpio-keys driver to ignore >>> the gpio number if an IRQ is passed. >>> >> >> I am (still) all fine with this, even though I like Dmitry's set. I >> suppose you already have a plan for merging this, but I still have to >> ask - why the MFD changes aren't in own patch? I feel it would have >> simplified merging, backporting, reviewing and reverting if needed. > > Splitting it out would break bisection: The gpio-leds change without > the mfd change causes a build failure when assigning the .gpio > field, and the reverse causes a runtime failure when .gpio=0 is > a valid line. Ah, yes. Thanks for explanation. (I feel a bit [a lot] stupid, as I somehow missed the problem of .gpio = 0 being valid. That even though I had it explicitly set to -1 myself :rolleyes: ). No further questions ;) Yours, -- Matti -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~