From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 09/11] clocksource: add TI 32.768 Hz counter driver Date: Wed, 7 Oct 2015 01:24:38 +0200 Message-ID: <56145836.4070304@linaro.org> References: <1444150927-14771-1-git-send-email-balbi@ti.com> <1444150927-14771-10-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1444150927-14771-10-git-send-email-balbi@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi , Tony Lindgren Cc: Linux OMAP Mailing List , Linux ARM Kernel Mailing List , tglx@linutronix.de, Linux Kernel Mailing List List-Id: linux-omap@vger.kernel.org On 10/06/2015 07:02 PM, Felipe Balbi wrote: > Introduce a new clocksource driver for Texas > Instruments 32.768 Hz device which is available > on most OMAP-like devices. > > Signed-off-by: Felipe Balbi Hi Felipe, With the couple of nits below fixed, you can my: Acked-by: Daniel Lezcano [ ... ] > +#define OMAP2_32KSYNCNT_REV_OFF 0x0 > +#define OMAP2_32KSYNCNT_REV_SCHEME (0x3 << 30) > +#define OMAP2_32KSYNCNT_CR_OFF_LOW 0x10 > +#define OMAP2_32KSYNCNT_CR_OFF_HIGH 0x30 > + > +struct ti_32k { > + void __iomem *base; > + void __iomem *counter; > + struct clocksource cs; > +}; > +#define to_ti_32k(cs) (container_of((cs), struct ti_32k, cs)) Usually a static inline is used instead of a macro for that. > +static cycle_t ti_32k_read_cycles(struct clocksource *cs) > +{ > + struct ti_32k *ti =3D to_ti_32k(cs); format --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog