From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH] extcon: palmas: add support for using VBUSDET output Date: Fri, 20 Nov 2015 14:44:18 +0900 Message-ID: <564EB332.5090406@samsung.com> References: <1447350781-20649-1-git-send-email-balbi@ti.com> <1447351034-21150-1-git-send-email-balbi@ti.com> <564EB0A6.4060407@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <564EB0A6.4060407@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi , Tony Lindgren , Rob Herring , MyungJoo Ham Cc: Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List List-Id: linux-omap@vger.kernel.org Hi Felipe, On 2015=EB=85=84 11=EC=9B=94 20=EC=9D=BC 14:33, Chanwoo Choi wrote: > Hi Felipe, >=20 > Looks good to me. But I have one comment. >=20 > On 2015=EB=85=84 11=EC=9B=94 13=EC=9D=BC 02:57, Felipe Balbi wrote: >> TPS659038 can remux its GPIO_1 as VBUSDET output, >> which can be tied to a SoC GPIO and used as a VBUS >> interrupt. >> >> Beagle X15 uses that, in fact, and without it, I >> could not get USB peripheral working with that >> board. >> >> Signed-off-by: Felipe Balbi >> --- >> drivers/extcon/extcon-palmas.c | 22 ++++++++++++++++++++-- >> 1 file changed, 20 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-= palmas.c >> index 93c30a885740..7985d092c069 100644 >> --- a/drivers/extcon/extcon-palmas.c >> +++ b/drivers/extcon/extcon-palmas.c >> @@ -296,10 +296,28 @@ static int palmas_usb_probe(struct platform_de= vice *pdev) >> } >> =20 >> if (palmas_usb->enable_vbus_detection) { >> + int irq =3D platform_get_irq(pdev, 0); >> + >> + if (irq > 0) { >> + /* remux GPIO_1 as VBUSDET */ >> + status =3D palmas_update_bits(palmas, PALMAS_PU_PD_OD_BASE, >> + PALMAS_PRIMARY_SECONDARY_PAD1, >> + PALMAS_PRIMARY_SECONDARY_PAD1_GPIO_1_MASK, >> + (1 << 3)); >=20 > PALMAS_PRIMARY_SECONDARY_PAD1_GPIO_1_SHIFT is appropriate instead of = using '3'. > Also, I don't recommend the over line 80. The everything else is good >=20 >=20 >> + if (status < 0) { >> + dev_err(&pdev->dev, "can't remux GPIO1\n"); >> + return status; >> + } >> + >> + palmas_usb->vbus_irq =3D irq; >> + } else { >> + irq =3D regmap_irq_get_virq(palmas->irq_data, >> + PALMAS_VBUS_IRQ); >> + palmas_usb->vbus_irq =3D irq; >> + } >> + >> palmas_usb->vbus_otg_irq =3D regmap_irq_get_virq(palmas->irq_data= , >> PALMAS_VBUS_OTG_IRQ); >> - palmas_usb->vbus_irq =3D regmap_irq_get_virq(palmas->irq_data, >> - PALMAS_VBUS_IRQ); >> status =3D devm_request_threaded_irq(palmas_usb->dev, >> palmas_usb->vbus_irq, NULL, >> palmas_vbus_irq_handler, >> >=20 > Thanks, > Chanwoo Choi > -- > To unsubscribe from this list: send the line "unsubscribe linux-kerne= l" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >=20 If you are OK about following patch, I'll apply it on extcon branch. diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-pal= mas.c index 93c30a885740..f601370c9466 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c @@ -296,10 +296,29 @@ static int palmas_usb_probe(struct platform_devic= e *pdev) } =20 if (palmas_usb->enable_vbus_detection) { + int irq =3D platform_get_irq(pdev, 0); + + if (irq > 0) { + /* remux GPIO_1 as VBUSDET */ + status =3D palmas_update_bits(palmas, + PALMAS_PU_PD_OD_BASE, + PALMAS_PRIMARY_SECONDARY_PAD1, + PALMAS_PRIMARY_SECONDARY_PAD1_GPIO_1_MASK, + (1 << PALMAS_PRIMARY_SECONDARY_PAD1_GPIO_1_SHIFT)); + if (status < 0) { + dev_err(&pdev->dev, "can't remux GPIO1\n"); + return status; + } + + palmas_usb->vbus_irq =3D irq; + } else { + irq =3D regmap_irq_get_virq(palmas->irq_data, + PALMAS_VBUS_IRQ); + palmas_usb->vbus_irq =3D irq; + } + palmas_usb->vbus_otg_irq =3D regmap_irq_get_virq(palmas->irq_data, PALMAS_VBUS_OTG_IRQ); - palmas_usb->vbus_irq =3D regmap_irq_get_virq(palmas->irq_data, - PALMAS_VBUS_IRQ); status =3D devm_request_threaded_irq(palmas_usb->dev, palmas_usb->vbus_irq, NULL, palmas_vbus_irq_handler, --=20 1.9.1 Thanks, Chanwoo Choi