From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [PATCH] ti/fapll: fix wrong do_div() usage Date: Tue, 24 Nov 2015 11:35:48 +0200 Message-ID: <56542F74.3080200@ti.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-clk-owner@vger.kernel.org To: Nicolas Pitre , Michael Turquette Cc: linux-omap@vger.kernel.org, linux-clk@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 11/04/2015 06:17 AM, Nicolas Pitre wrote: > do_div() is meant to be used with an unsigned dividend. > > Signed-off-by: Nicolas Pitre Fixed Subject locally to format "clk: ti: %s". Queued for 4.4-rc-fixes, thanks. -Tero > > diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c > index f4b2e9888b..66a0d0ed8b 100644 > --- a/drivers/clk/ti/fapll.c > +++ b/drivers/clk/ti/fapll.c > @@ -168,7 +168,7 @@ static unsigned long ti_fapll_recalc_rate(struct clk_hw *hw, > { > struct fapll_data *fd = to_fapll(hw); > u32 fapll_n, fapll_p, v; > - long long rate; > + u64 rate; > > if (ti_fapll_clock_is_bypass(fd)) > return parent_rate; > @@ -314,7 +314,7 @@ static unsigned long ti_fapll_synth_recalc_rate(struct clk_hw *hw, > { > struct fapll_synth *synth = to_synth(hw); > u32 synth_div_m; > - long long rate; > + u64 rate; > > /* The audio_pll_clk1 is hardwired to produce 32.768KiHz clock */ > if (!synth->div) >