From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v4] clocksource: arm_global_timer: fix suspend resume Date: Fri, 18 Dec 2015 15:14:10 +0200 Message-ID: <567406A2.1050906@ti.com> References: <1448907912-15512-1-git-send-email-grygorii.strashko@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1448907912-15512-1-git-send-email-grygorii.strashko@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Lezcano , Thomas Gleixner , Srinivas Kandagatla , Maxime Coquelin Cc: Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com, linux-omap@vger.kernel.org, Santosh Shilimkar , Arnd Bergmann , John Stultz , Felipe Balbi , Tony Lindgren , Marc Zyngier List-Id: linux-omap@vger.kernel.org Hi All, On 11/30/2015 08:25 PM, Grygorii Strashko wrote: > Now the System stall is observed on TI AM437x based board > (am437x-gp-evm) during resuming from System suspend when ARM Global > timer is selected as clocksource device (CPUIdle not enabled) - SysRq are working, > but nothing else. > > The reason of stall is that ARM Global timer loses its contexts during > System suspend: > GT_CONTROL.TIMER_ENABLE = 0 (unbanked) > GT_COUNTERx = 0 > > Hence, update ARM Global timer driver to reflect above behaviour > - re-enable ARM Global timer on resume (GT_CONTROL.TIMER_ENABLE = 1) > if not enabled. > > CC: Arnd Bergmann > Cc: John Stultz > Cc: Felipe Balbi > Cc: Tony Lindgren > Cc: Marc Zyngier > Reviewed-by: Santosh Shilimkar > Signed-off-by: Grygorii Strashko Are there any comments? Do I need to perform any additional actions to have it merged? -- regards, -grygorii