From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: Nokia N900: Proper C-states Date: Tue, 9 Feb 2016 18:06:26 +0100 Message-ID: <56BA1C92.4040202@linaro.org> References: <201601021526.28687@pali> <56884890.9080306@linaro.org> <20160209155619.GG19432@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160209155619.GG19432@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Jean Pihet , Santosh Shilimkar , Kevin Hilman , Nishanth Menon , Pavel Machel , Aaro Koskinen , Sebastian Reichel , Ivaylo Dimitrov , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi List-Id: linux-omap@vger.kernel.org On 02/09/2016 04:56 PM, Tony Lindgren wrote: > * Daniel Lezcano [160102 14:01]: >> On 01/02/2016 03:26 PM, Pali Roh=C3=A1r wrote: >>> Hello, >>> >>> due to this Daniel Lezcano commit (ARM: OMAP3: cpuidle - remove rx5= 1 >>> cpuidle parameters table) >>> >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/com= mit/?id=3D231900afba52d6faddfb480cde4132d4edc089bc >>> >>> we need patch cpuidle34xx.c code to fix commit for Nokia N900. See: >>> >>> https://github.com/pali/linux-n900/commit/e147fd4b678f1f3d7a5235287= 910960bd41e04dc >>> >>> As Nokia N900 code is converting from legacy board code to DST, I w= ould >>> like to know how to patch correctly omap3_idle_driver in DTS with >>> correct values measured for Nokia N900. Thanks! > > I'm almost certain those values are not n900 specific but should be > used for omap3430 in general. > >> the conversion to the DT based arm cpuidle driver could be a bit com= plex >> with one issue (index 0 !=3D cpu_do_idle()) and one performance regr= ession >> (cpu_pm_enter/exit will be called in retention mode, even if this is= not >> needed). >> >> It will result in a PM code only on one side and on the other side, = the >> generic cpuidle-arm.c driver will be used instead with the DT defini= tion. It >> is worth to the conversion because the result will be nice IMO. >> >> Added Lorenzo who is initially author of the arm generic driver. We = already >> discussed in the past about those two issues above and I think this = is >> something we should improve. > > While this conversion process is going on, we could just add > omap3430_idle_driver and set that based on cpu_is_omap3430() > in omap3_idle_init(). Yes, that could be a temporary alternative. --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog