From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH v5 09/26] mtd: nand: omap: Clean up device tree support Date: Mon, 7 Mar 2016 11:02:58 +0200 Message-ID: <56DD43C2.2080406@ti.com> References: <1455916548-3441-1-git-send-email-rogerq@ti.com> <1455916548-3441-10-git-send-email-rogerq@ti.com> <20160305022823.GO55664@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160305022823.GO55664-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org, javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org, fcooper-l0cyMroinI0@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On 05/03/16 04:28, Brian Norris wrote: > Sorry, another small thing I noticed. > > On Fri, Feb 19, 2016 at 11:15:31PM +0200, Roger Quadros wrote: >> Move NAND specific device tree parsing to NAND driver. >> >> The NAND controller node must have a compatible id, register space >> resource and interrupt resource. >> >> Signed-off-by: Roger Quadros >> --- > [...] > >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c >> index 9e99199..0a637c4 100644 >> --- a/drivers/mtd/nand/omap2.c >> +++ b/drivers/mtd/nand/omap2.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> #include >> @@ -177,10 +178,11 @@ struct omap_nand_info { >> struct gpmc_nand_regs reg; >> struct gpmc_nand_ops *ops; >> /* generated at runtime depending on ECC algorithm and layout selected */ > > ^^^ I don't think that comment describes the following line. You > probably meant to delete this one? Yes. I'll remove that. Was my bad on cherry-pick conflict resolution. > >> + bool flash_bbt; >> + /* generated at runtime depending on ECC algorithm and layout */ >> struct nand_ecclayout oobinfo; >> /* fields specific for BCHx_HW ECC scheme */ >> struct device *elm_dev; >> - struct device_node *of_node; >> }; >> >> static inline struct omap_nand_info *mtd_to_omap(struct mtd_info *mtd) > > [...] > cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html