From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH v6 04/10] usb: dwc3: omap: fix up error path on probe() Date: Mon, 11 Apr 2016 16:09:45 +0300 Message-ID: <570BA219.3000606@ti.com> References: <1460374506-9779-1-git-send-email-rogerq@ti.com> <1460374506-9779-5-git-send-email-rogerq@ti.com> <87bn5gnxp9.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <87bn5gnxp9.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org, peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org, grygorii.strashko-l0cyMroinI0@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On 11/04/16 15:20, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> From: Felipe Balbi >> >> Even if pm_runtime_get*() fails, we *MUST* call >> pm_runtime_put_sync() before disabling PM. >> >> While at it, remove superfluous dwc3_omap_disable_irqs() >> in error path. >> >> Signed-off-by: Felipe Balbi >> [nsekhar-l0cyMroinI0@public.gmane.org: patch description updates] >> Signed-off-by: Sekhar Nori >> Signed-off-by: Roger Quadros > > this fix is unrelated to DRD/OTG work, right ? Care to rebase only this > patch on v4.6-rc3 so I can apply it during current -rc ? > Sure, will do that. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html