From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core Date: Wed, 20 Apr 2016 09:47:38 +0300 Message-ID: <5717260A.3070601@ti.com> References: <1459865117-7032-1-git-send-email-rogerq@ti.com> <1459865117-7032-9-git-send-email-rogerq@ti.com> <20160418062937.GA4477@shlinux2.ap.freescale.net> <20160419081446.GA15789@shlinux2.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160419081446.GA15789-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Chen Cc: stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org, mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, r.baldyga-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On 19/04/16 11:14, Peter Chen wrote: > On Mon, Apr 18, 2016 at 02:29:37PM +0800, Peter Chen wrote: >> On Tue, Apr 05, 2016 at 05:05:13PM +0300, Roger Quadros wrote: >>> Introduce usb_otg_add/remove_hcd() for use by host >>> controllers that are part of OTG/dual-role port. >>> >>> Non Device tree platforms can use the otg_dev argument >>> to specify the OTG controller device. If otg_dev is NULL >>> then the device tree node's otg-controller property is used to >>> get the otg_dev device. >>> >>> Signed-off-by: Roger Quadros >>> --- >>> drivers/usb/core/hcd.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++ >>> include/linux/usb/hcd.h | 4 +++ >>> 2 files changed, 75 insertions(+) >>> >>> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c >>> index 6b1930d..6a80193 100644 >>> --- a/drivers/usb/core/hcd.c >>> +++ b/drivers/usb/core/hcd.c >>> @@ -46,6 +46,10 @@ >>> #include >>> #include >>> #include >>> +#include >>> + >>> +#include >>> +#include >>> >>> #include "usb.h" >>> >>> @@ -3013,6 +3017,73 @@ void usb_remove_hcd(struct usb_hcd *hcd) >>> } >>> EXPORT_SYMBOL_GPL(usb_remove_hcd); >>> >>> + >>> +static struct otg_hcd_ops otg_hcd_intf = { >>> + .add = usb_add_hcd, >>> + .remove = usb_remove_hcd, >>> + .usb_bus_start_enum = usb_bus_start_enum, >>> + .usb_control_msg = usb_control_msg, >>> + .usb_hub_find_child = usb_hub_find_child, >>> +}; >>> + >>> +/** >>> + * usb_otg_add_hcd - Register the HCD with OTG core. >>> + * @hcd: the usb_hcd structure to initialize >>> + * @irqnum: Interrupt line to allocate >>> + * @irqflags: Interrupt type flags >>> + * @otg_dev: OTG controller device manging this HCD >> >> %s/manging/managing >> >>> + * >>> + * Registers the HCD with OTG core. OTG core will call usb_add_hcd() >>> + * or usb_remove_hcd() as necessary. >>> + * If otg_dev is NULL then device tree node is checked for OTG >>> + * controller device via the otg-controller property. >>> + */ >>> +int usb_otg_add_hcd(struct usb_hcd *hcd, >>> + unsigned int irqnum, unsigned long irqflags, >>> + struct device *otg_dev) >>> +{ >> >> Some users may not want to use default otg_hcd_ops, would you please >> add one more parameter (eg, hcd_ops) for that? If hcd_ops is NULL, just >> use the default one. >> > > I forgot there is .start_host at otg fsm API when reviewing, so it is > ok to have a unified hcd_ops, the user can do platform things at > fsm.start_host. > OK, great :). cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html