From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helen Koike Subject: Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support Date: Mon, 20 Jun 2016 17:12:29 -0300 Message-ID: <57684E2D.8040508@collabora.co.uk> References: <20160618104038.GB31665@earth> <57684795.8050705@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <57684795.8050705@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen , Sebastian Reichel Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, k.kozlowski@samsung.com, lgirdwood@gmail.com, peter.ujfalusi@ti.com, broonie@kernel.org, cphealy@gmail.com, linux-omap@vger.kernel.org, jarkko.nikula@bitmer.com List-Id: linux-omap@vger.kernel.org On 20-06-2016 16:44, Lars-Peter Clausen wrote: >> + /* before widget power up */ >> + if (SND_SOC_DAPM_EVENT_ON(event)) { >> + /* Turn on the chip */ >> + tpa6130a2_power(data, true); >> + /* Sync the registers */ >> + ret = regcache_sync(data->regmap); >> + if (ret < 0) { >> + dev_err(c->dev, "Failed to initialize chip\n"); >> + tpa6130a2_power(data, false); >> + return ret; >> + } >> + /* after widget power down */ >> + } else >> + tpa6130a2_power(data, false); > > checkpatch.pl should complain about this. Kernel code style is if one branch > has branches the other has to have it as well. > Weird, checkpatch.pl doesn't complain. I'll add the braces in v3, thank you for reviewing