Re: [PATCH] ARM: OMAP: Define use internal clock field in MMC configuration

["Trilok Soni" <soni.trilok@gmail.com>]

On 5/28/07, Kyungmin Park <kmpark@infradead.org> wrote:
> Hi,
>
> With the recent omap24xx register cleanup, the CONTROL_DEVCONF is only defined
> at arch/arm/mach-omap2/pm.c.
> So define 24XX_CONTROL_DEVCONF and use internal clock field in MMC
> configuration.
> I think it's the proper place to set mmc clock instead of board-specific one.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> --
> diff --git a/arch/arm/mach-omap2/board-apollon.c
> b/arch/arm/mach-omap2/board-apollon.c
> index 1276f1f..75c9f3e 100644
> --- a/arch/arm/mach-omap2/board-apollon.c
> +++ b/arch/arm/mach-omap2/board-apollon.c
> @@ -251,6 +251,8 @@ static struct omap_mmc_config apollon_mmc_config __initdata
> = {
>        .mmc [0] = {
>                .enabled        = 1,
>                .wire4          = 1,
> +       /* Use Interal loop-back in MMC/SDIO Module Input Clock selection */

Typo. s/Interal/Internal

> +               .internal_clock = 1,
>                .wp_pin         = -1,
>                .power_pin      = -1,
>        /* Note: If you want to detect card feature, please assign 37 */
> @@ -311,9 +313,6 @@ static void __init omap_apollon_init(void)
>        apollon_flash_init();
>        apollon_usb_init();
>
> -       /* Use Interal loop-back in MMC/SDIO Module Input Clock selection */
> -       CONTROL_DEVCONF |= (1 << 24);
> -
>        /*
>         * Make sure the serial ports are muxed on at this point.
>         * You have to mux them off in device drivers later on
> diff --git a/arch/arm/plat-omap/devices.c b/arch/arm/plat-omap/devices.c
> index f8a341b..80d03e2 100644
> --- a/arch/arm/plat-omap/devices.c
> +++ b/arch/arm/plat-omap/devices.c
> @@ -339,6 +339,17 @@ static void __init omap_init_mmc(void)
>                                omap_cfg_reg(MMC_DAT3);
>                        }
>                }
> +               if (mmc->internal_clock) {
> +                       /*
> +                        * Use Interal loop-back in MMC/SDIO
> +                        * Module Input Clock selection
> +                        */

Typo. s/Interal/Internal


> +                       if (cpu_is_omap24xx()) {
> +                               u32 v = omap_readl(OMAP24XX_CONTROL_DEVCONF);
> +                               v |= (1 << 24);
> +                               omap_writel(v, OMAP24XX_CONTROL_DEVCONF);
> +                       }
> +               }
>                mmc1_conf = *mmc;
>                (void) platform_device_register(&mmc_omap_device1);
>        }


-- 
--Trilok Soni