Re: [PATCH 1/2] ov9640: Add OmniVision ov9640 driver - new interface

["Trilok Soni" <soni.trilok@gmail.com>]

Hi Tony,

On 9/1/07, Tony Lindgren <tony@atomide.com> wrote:
> * Trilok Soni <trilok_soni@yahoo.co.in> [070823 05:29]:
> > Hi,
> >
> > --- Trilok Soni <soni.trilok@gmail.com> wrote:
> >
> > > Hi Sakari,
> > >
> > > On 8/20/07, Sakari Ailus <sakari.ailus@nokia.com>
> > > wrote:
> > > > ext Trilok Soni wrote:
> > > > > Hi All,
> > > >
> > > > Hi, Trilok!
> > > >
> > > > > I have attached two patches which converts the
> > > ov9640 driver to use
> > > > > the new v4l2 sensor interface. Sensor detection
> > > is working with H4 but
> > > > > the output is not anywhere near to correct, so
> > > someone with H4 please
> > > > > check and give inputs.
> > > > >
> > > > > Patches are implemented and tested against
> > > mainline kernel and OMAP2
> > > > > camera driver posted by Sakari to v4l mailing
> > > list [1].
> > > >
> > > >  > +#define NUM_IOCTLS 16
> > > > ...
> > > >  > +     /* Just an experiment --- don't use *_cb
> > > functions yet. */
> > > >  > +     ov9640_ioctl_desc[i++] =
> > > vidioc_int_dev_init_cb(&ioctl_dev_init);
> > > >  > +     BUG_ON(i >= NUM_IOCTLS);
> > > >
> > > > These are leftovers from the
> > > check-slave-interface-types experiment
> > > > which probably should be removed. This applies to
> > > TCM825x as well.
> > > >
> > >
> > > I will remove that and update the patch once camera
> > > output is correct.
> > >
> >
> > I have attached the updated ov9640 patch with
> > v4l2_ifparm addition and some cosmetic changes, sensor
> > still not working except detection.
>
> Trilok, can you please refresh this patch?
>

I will do this. But please note that new ov9640.[ch] is now outside
"omap" directory as compared to linux-omap git tree.

-- 
--Trilok Soni