Re: [PATCH 04/25] i2c: move twl4030_keypad to new style registration

Felipe Balbi
2008-09-30T22:30:47Z

On Tue, Sep 30, 2008 at 02:42:47PM -0700, David Brownell wrote:
> On Tuesday 30 September 2008, Felipe Balbi wrote:
> > +struct twl4030_keypad_data {
> > +       int rows;
> > +       int cols;
> > +       int *keymap;
> > +       int irq;
> > +       unsigned int keymapsize;
> > +       unsigned int rep:1;
> > +};
>
> To fix later: "irq" should be a standard platform resource.
>
> Those references in board init code to TWL4030_MODIRQ_KEYPAD
> should vanish, and add_children() should just pass the right
> number the standard way.

Cool, could you take a look at twl4030-bci changes ?? They request both
irqs, which seems ok, but then we won't be able to get rid of
TWL4030_MODIRQ_BCI.

If you can come up with an idea to change that, i'd be glad.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html