Re: [PATCH 09/25] i2c: move twl4030-madc to new registration style

David Brownell
2008-09-30T21:45:22Z

On Tuesday 30 September 2008, Felipe Balbi wrote:
>         ret = request_irq(TWL4030_MODIRQ_MADC, twl4030_madc_irq_handler,

Likewise: pass the IRQ through a platform driver resource.
These TWL4030_MODIRQ_* symbols should vanish.

(To fix later. No reason to hold up this batch of patches
any longer...)

> -                         IRQF_DISABLED, "twl4030_madc", &twl4030_madc);
> -       if (ret)
> -               printk(KERN_ERR TWL4030_MADC_PFX "request_irq: %d\n", ret);
> +                         IRQF_DISABLED, "twl4030_madc", madc);
> +       if (ret) {
> +               dev_dbg(&pdev->dev, "could not request irq\n");
> +               goto err_irq;
> +       }

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html