Re: [PATCH 1/3] ti-soc-thermal: Use devm_kcalloc() in ti_bandgap_build()

Keerthy
2017-05-02T03:55:56Z

On Wednesday 26 April 2017 09:04 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 26 Apr 2017 16:45:25 +0200
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kcalloc".

Reviewed-by: Keerthy <j-keerthy@ti.com>

>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index ba9c302454fb..f19cb7612a65 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -1224,8 +1224,8 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
> bgp->conf = of_id->data;
>
> /* register shadow for context save and restore */
> - bgp->regval = devm_kzalloc(&pdev->dev, sizeof(*bgp->regval) *
> - bgp->conf->sensor_count, GFP_KERNEL);
> + bgp->regval = devm_kcalloc(&pdev->dev, bgp->conf->sensor_count,
> + sizeof(*bgp->regval), GFP_KERNEL);
> if (!bgp->regval) {
> dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
> return ERR_PTR(-ENOMEM);
>