From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Kevin Hilman <khilman@ti.com>, linux-omap@vger.kernel.org
Cc: Paul Walmsely <paul@pwsan.com>, Benoit Cousson <b-cousson@ti.com>
Subject: RE: [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD structure
Date: Sat, 19 Mar 2011 10:11:53 +0530 [thread overview]
Message-ID: <6002d9aa481856ee6e703e8f6cbda767@mail.gmail.com> (raw)
In-Reply-To: <1300493932-17362-3-git-send-email-khilman@ti.com>
Minor comment.
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Kevin Hilman
> Sent: Saturday, March 19, 2011 5:49 AM
> To: linux-omap@vger.kernel.org
> Cc: Paul Walmsely; Benoit Cousson
> Subject: [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD
> structure
>
> Eliminate need for global variables for the various PRM module
> offsets by
> making them part of the VDD structure.
>
> Eventually, these will likely be moved again, or more likely
> removed,
> but for now just getting rid of them as global variabes so that the
> voltage domain initialization can be cleaned up.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> arch/arm/mach-omap2/voltage.c | 109 ++++++++++++--
> -----------
> arch/arm/mach-omap2/voltage.h | 6 +-
> arch/arm/mach-omap2/voltagedomains3xxx_data.c | 10 +-
> arch/arm/mach-omap2/voltagedomains44xx_data.c | 12 ++-
> 4 files changed, 67 insertions(+), 70 deletions(-)
>
[....]
> diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-
> omap2/voltage.h
> index e9f5408..44edc1e 100644
> --- a/arch/arm/mach-omap2/voltage.h
> +++ b/arch/arm/mach-omap2/voltage.h
> @@ -133,6 +133,9 @@ struct omap_vdd_info {
> struct dentry *debug_dir;
> u32 curr_volt;
> bool vp_enabled;
> +
> + s16 prm_mod;
> + s16 prm_irqst_mod;
Can you also add kernel doc for above two
entries?
> u32 (*read_reg) (u16 mod, u8 offset);
> void (*write_reg) (u32 val, u16 mod, u8 offset);
> int (*volt_scale) (struct omap_vdd_info *vdd,
> @@ -151,8 +154,7 @@ struct omap_volt_data
> *omap_voltage_get_voltdata(struct voltagedomain *voltdm,
> unsigned long volt);
> unsigned long omap_voltage_get_nom_volt(struct voltagedomain
> *voltdm);
> struct dentry *omap_voltage_get_dbgdir(struct voltagedomain
> *voltdm);
> -int __init omap_voltage_early_init(s16 prm_mod, s16 prm_irqst_mod,
> - struct omap_vdd_info *omap_vdd_array[],
> +int __init omap_voltage_early_init(struct omap_vdd_info
> *omap_vdd_array[],
> u8 omap_vdd_count);
> #ifdef CONFIG_PM
> int omap_voltage_register_pmic(struct voltagedomain *voltdm,
next prev parent reply other threads:[~2011-03-19 4:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 0:18 [PATCH 0/7] OMAP2+: voltage layer cleanup and restructure Kevin Hilman
2011-03-19 0:18 ` [PATCH 1/7] OMAP2+: hwmod: remove unused voltagedomain pointer Kevin Hilman
2011-03-21 13:08 ` Cousson, Benoit
2011-03-21 15:32 ` Kevin Hilman
2011-03-24 13:03 ` Gulati, Shweta
2011-03-24 14:00 ` Kevin Hilman
2011-03-24 15:14 ` Cousson, Benoit
2011-03-25 5:00 ` Gulati, Shweta
2011-03-22 19:13 ` Paul Walmsley
2011-03-19 0:18 ` [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD structure Kevin Hilman
2011-03-19 4:41 ` Santosh Shilimkar [this message]
2011-03-21 15:21 ` Kevin Hilman
2011-03-21 10:53 ` Premi, Sanjeev
2011-03-21 15:26 ` Kevin Hilman
2011-03-23 14:16 ` Kevin Hilman
2011-03-19 0:18 ` [PATCH 3/7] OMAP2+: voltage: start towards a new voltagedomain layer Kevin Hilman
2011-03-19 0:18 ` [PATCH 4/7] OMAP2+: powerdomain: add voltage domain lookup during register Kevin Hilman
2011-03-22 19:23 ` Paul Walmsley
2011-03-22 20:59 ` Cousson, Benoit
2011-03-22 22:08 ` Paul Walmsley
2011-03-22 23:04 ` Cousson, Benoit
2011-04-02 1:17 ` Paul Walmsley
2011-03-23 0:17 ` Kevin Hilman
2011-03-19 0:18 ` [PATCH 5/7] OMAP2+: voltage: keep track of powerdomains in each voltagedomain Kevin Hilman
2011-03-22 19:35 ` Paul Walmsley
2011-03-23 0:18 ` Kevin Hilman
2011-03-19 0:18 ` [PATCH 6/7] OMAP2+: voltage: move prm_irqst_reg from VP into voltage domain Kevin Hilman
2011-03-19 0:18 ` [PATCH 7/7] OMAP3: powerdomain data: add voltage domains Kevin Hilman
2011-03-22 19:30 ` Paul Walmsley
2011-03-22 21:09 ` Cousson, Benoit
2011-03-22 22:15 ` Paul Walmsley
2011-03-23 0:20 ` Kevin Hilman
2011-03-23 0:31 ` [PATCH 0/7] OMAP2+: voltage layer cleanup and restructure Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6002d9aa481856ee6e703e8f6cbda767@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).