From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time
Date: Thu, 01 Nov 2018 18:17:43 +0200 [thread overview]
Message-ID: <6319156.NE1xsugdhs@avalon> (raw)
In-Reply-To: <20181101155856.GB56754@atomide.com>
Hi Tony,
On Thursday, 1 November 2018 17:58:56 EET Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [181101 12:13]:
> > On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote:
> > > We do dispc_runtime_get/put in the HDMI driver's suspend/resume too, so
> > > don't we need similar hack (as you add in dsi.c) there also?
> >
> > We would if we had to access HDMI registers at probe time.
>
> With these I'm still seeing the following issue with hdmi on rmmod
> of omapdrm related modules as hdmi->dss is NULL in hdmi_runtime_resume.
This is actually what I expected, but to my surprise the problem didn't occur
on my system, I don't know why. I'll try to investigate.
> Regards,
>
> Tony
>
> 8< ------
> Unable to handle kernel NULL pointer dereference at virtual address 00000278
> ...
> PC is at hdmi_runtime_resume+0xc/0x1c [omapdss]
> LR is at __rpm_callback+0x144/0x1d8
> ...
> (hdmi_runtime_resume [omapdss]) from [<c06079b4>]
> (__rpm_callback+0x144/0x1d8) (__rpm_callback) from [<c0607a68>]
> (rpm_callback+0x20/0x80)
> (rpm_callback) from [<c06075f0>] (rpm_resume+0x60c/0x828)
> (rpm_resume) from [<c0607858>] (__pm_runtime_resume+0x4c/0x64)
> (__pm_runtime_resume) from [<c05fc7ec>]
> (device_release_driver_internal+0x130/0x234)
> (device_release_driver_internal) from [<c05fc934>]
> (driver_detach+0x38/0x6c) (driver_detach) from [<c05fb698>]
> (bus_remove_driver+0x4c/0xa4)
> (bus_remove_driver) from [<c05fe23c>]
> (platform_unregister_drivers+0x20/0x2c) (platform_unregister_drivers) from
> [<c01f0fe0>] (sys_delete_module+0x1c0/0x230) (sys_delete_module) from
> [<c0101000>] (ret_fast_syscall+0x0/0x28)
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-11-01 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 10:25 [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time Laurent Pinchart
2018-11-01 10:25 ` [PATCH 1/3] drm/omap: Populate DSS children in omapdss driver Laurent Pinchart
2018-11-01 10:25 ` [PATCH 2/3] drm/omap: hdmi4: Ensure the device is active during bind Laurent Pinchart
2018-11-01 10:25 ` [PATCH 3/3] drm/omap: dsi: Ensure the device is active during probe Laurent Pinchart
2018-11-01 11:47 ` [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time Tomi Valkeinen
2018-11-01 12:13 ` Laurent Pinchart
2018-11-01 12:56 ` Tomi Valkeinen
2018-11-01 15:58 ` Tony Lindgren
2018-11-01 16:17 ` Laurent Pinchart [this message]
2018-11-05 15:14 ` Laurent Pinchart
2018-11-05 20:15 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6319156.NE1xsugdhs@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox