public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* OMAP: TWL4030: Sound broken in 3.1
@ 2011-11-04 15:18 Joe Woodward
  2011-11-04 15:28 ` Péter Ujfalusi
  0 siblings, 1 reply; 4+ messages in thread
From: Joe Woodward @ 2011-11-04 15:18 UTC (permalink / raw)
  To: linux-omap

In 3.1 sound support is broken for any boards using a TWL4030-based CODEC.

The Kconfig option for the TWL4030 CODEC used to be TWL4030_CODEC, and in 
3.1 this has been changed to MFD_TWL4030_AUDIO.

I believe this has caused a problem in drives/mfd/twl-core.c:112 as the 
define for the twl_has_codec() macro still tests for CONFIG_TWL4030_CODEC. 
Hence the macro always returns false and during boot I get:

[    2.417999] ALSA device list:
[    2.421142]   No soundcards found.

Is this likely to be the problem?

Cheers,
Joe



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: OMAP: TWL4030: Sound broken in 3.1
  2011-11-04 15:18 OMAP: TWL4030: Sound broken in 3.1 Joe Woodward
@ 2011-11-04 15:28 ` Péter Ujfalusi
  0 siblings, 0 replies; 4+ messages in thread
From: Péter Ujfalusi @ 2011-11-04 15:28 UTC (permalink / raw)
  To: Joe Woodward; +Cc: linux-omap

On Friday 04 November 2011 15:18:05 Joe Woodward wrote:
> In 3.1 sound support is broken for any boards using a TWL4030-based CODEC.
> 
> The Kconfig option for the TWL4030 CODEC used to be TWL4030_CODEC, and in
> 3.1 this has been changed to MFD_TWL4030_AUDIO.
> 
> I believe this has caused a problem in drives/mfd/twl-core.c:112 as the
> define for the twl_has_codec() macro still tests for CONFIG_TWL4030_CODEC.
> Hence the macro always returns false and during boot I get:
> 
> [    2.417999] ALSA device list:
> [    2.421142]   No soundcards found.
> 
> Is this likely to be the problem?

See Jarkko's patch:
https://lkml.org/lkml/2011/10/19/125

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: OMAP: TWL4030: Sound broken in 3.1
@ 2011-11-04 18:49 Thomas Weber
  2011-11-04 18:53 ` Ujfalusi, Peter
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Weber @ 2011-11-04 18:49 UTC (permalink / raw)
  To: Péter Ujfalusi, Joe Woodward; +Cc: linux-omap

Isn't this patch fixing it already?

https://lkml.org/lkml/2011/9/5/37

Thomas

Péter Ujfalusi <peter.ujfalusi@ti.com> wrote:

>On Friday 04 November 2011 15:18:05 Joe Woodward wrote:
>> In 3.1 sound support is broken for any boards using a TWL4030-based CODEC.
>> 
>> The Kconfig option for the TWL4030 CODEC used to be TWL4030_CODEC, and in
>> 3.1 this has been changed to MFD_TWL4030_AUDIO.
>> 
>> I believe this has caused a problem in drives/mfd/twl-core.c:112 as the
>> define for the twl_has_codec() macro still tests for CONFIG_TWL4030_CODEC.
>> Hence the macro always returns false and during boot I get:
>> 
>> [    2.417999] ALSA device list:
>> [    2.421142]   No soundcards found.
>> 
>> Is this likely to be the problem?
>
>See Jarkko's patch:
>https://lkml.org/lkml/2011/10/19/125
>
>--
>Péter
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: OMAP: TWL4030: Sound broken in 3.1
  2011-11-04 18:49 Thomas Weber
@ 2011-11-04 18:53 ` Ujfalusi, Peter
  0 siblings, 0 replies; 4+ messages in thread
From: Ujfalusi, Peter @ 2011-11-04 18:53 UTC (permalink / raw)
  To: Thomas Weber; +Cc: Joe Woodward, linux-omap

On Fri, Nov 4, 2011 at 8:49 PM, Thomas Weber
<thomas.weber.linux@googlemail.com> wrote:
> Isn't this patch fixing it already?
>
> https://lkml.org/lkml/2011/9/5/37

Yes, it should.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-11-04 18:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-04 15:18 OMAP: TWL4030: Sound broken in 3.1 Joe Woodward
2011-11-04 15:28 ` Péter Ujfalusi
  -- strict thread matches above, loose matches on Subject: below --
2011-11-04 18:49 Thomas Weber
2011-11-04 18:53 ` Ujfalusi, Peter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox