From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivaylo Dimitrov Subject: Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers Date: Mon, 5 Mar 2018 20:35:10 +0200 Message-ID: <6583654d-5250-a8a9-42e7-6b9990cd538c@gmail.com> References: <20180227222740.2150-1-merlijn@wizzup.org> <20180227222740.2150-2-merlijn@wizzup.org> <20180228215943.GI5448@atomide.com> <20180305173802.GB14921@uda0271908> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180305173802.GB14921@uda0271908> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Bin Liu , Tony Lindgren Cc: Merlijn Wajer , linux-omap@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org Hi, On 5.03.2018 19:38, Bin Liu wrote: > On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: >> * Merlijn Wajer [180227 22:29]: >>> Without pm_runtime_{get,put}_sync calls in place, reading >>> vbus status via /sys causes the following error: >>> >>> Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 >>> pgd = b333e822 >>> [fa0ab060] *pgd=48011452(bad) >>> >>> [] (musb_default_readb) from [] (musb_vbus_show+0x58/0xe4) >>> [] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44) >>> [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x80/0xdc) >>> [] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448) >>> [] (seq_read) from [] (__vfs_read+0x1c/0x118) >>> [] (__vfs_read) from [] (vfs_read+0x90/0x144) >>> [] (vfs_read) from [] (SyS_read+0x3c/0x74) >>> [] (SyS_read) from [] (ret_fast_syscall+0x0/0x54) >>> >>> Solution was suggested by Tony Lindgren . >>> >>> Signed-off-by: Merlijn Wajer >> >> Thanks for fixing this. Assuming it passes Bin's tests: >> >> Acked-by: Tony Lindgren > > Applied and sent out. Thanks. > What about stable kernels? Shouldn't this be fixed there as well? Ivo