From: Roger Quadros <rogerq@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
tony@atomide.com
Cc: robh+dt@kernel.org, grygorii.strashko@ti.com, nm@ti.com,
lokeshvutla@ti.com, nsekhar@ti.com, miquel.raynal@bootlin.com,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 8/8] memory: gpmc-omap: "gpmc,device-width" DT property is optional
Date: Wed, 15 Sep 2021 11:47:39 +0300 [thread overview]
Message-ID: <6a06f4bd-f20a-8b5a-c152-0877707670ff@kernel.org> (raw)
In-Reply-To: <e0c4759b-7c2d-e32c-f912-8409c1f65b49@canonical.com>
Hi Krzysztof,
On 15/09/2021 10:12, Krzysztof Kozlowski wrote:
> On 14/09/2021 14:27, Roger Quadros wrote:
>> Check for valid gpmc,device-width, nand-bus-width and bank-width
>> at one place. Default to 8-bit width if none present.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>> drivers/memory/omap-gpmc.c | 41 ++++++++++++++++++++++++--------------
>> 1 file changed, 26 insertions(+), 15 deletions(-)
>>
>
> All the comments from v3 are still applicable because it seems you
> ignored them. Please respond to them.
>
> It's the second patch where the reviewer's comments got lost, so it
> creates rather poor impression.
I was wondering what comments and then realized that gmail server has put
all your messages into spam folder.
I'm very sorry about that. I will address your comments ASAP.
cheers,
-roger
next prev parent reply other threads:[~2021-09-15 8:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 12:26 [PATCH v4 0/8] dt-bindings: memory-controllers: ti,gpmc: Convert to yaml Roger Quadros
2021-09-14 12:26 ` [PATCH v4 1/8] ARM: dts: omap: Fixup GPMC child nodes Roger Quadros
2021-09-15 6:53 ` Krzysztof Kozlowski
2021-09-14 12:26 ` [PATCH v4 2/8] dt-bindings: mtd: Remove gpmc-nor.txt Roger Quadros
2021-09-21 20:38 ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 3/8] dt-bindings: net: Remove gpmc-eth.txt Roger Quadros
2021-09-21 20:38 ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 4/8] dt-bindings: memory-controllers: Introduce ti,gpmc-child Roger Quadros
2021-09-21 20:40 ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 5/8] dt-bindings: mtd: ti,gpmc-nand: Convert to yaml Roger Quadros
2021-09-21 20:43 ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 6/8] dt-bindings: mtd: ti,gpmc-onenand: " Roger Quadros
2021-09-21 20:45 ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 7/8] dt-bindings: memory-controllers: ti,gpmc: " Roger Quadros
2021-09-15 7:20 ` Krzysztof Kozlowski
2021-10-07 8:03 ` Roger Quadros
2021-09-21 20:47 ` Rob Herring
2021-09-14 12:27 ` [PATCH v4 8/8] memory: gpmc-omap: "gpmc,device-width" DT property is optional Roger Quadros
2021-09-15 7:12 ` Krzysztof Kozlowski
2021-09-15 8:47 ` Roger Quadros [this message]
2021-09-15 9:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a06f4bd-f20a-8b5a-c152-0877707670ff@kernel.org \
--to=rogerq@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=miquel.raynal@bootlin.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox