RE: [PATCH 0/3] OMAP2+ hwmod fixes

Paul Walmsley
2011-02-22T19:09:57Z

Hi Rajendra

On Tue, 22 Feb 2011, Rajendra Nayak wrote:

> The original behavior of the iterators, to terminate upon
> encountering an error, seems fine to me. The only problem
> I faced was that they fail silently and go undetected, unless
> their user catches the return value and WARN's, which I found
> was not the case with most users, mainly those of
> omap_hwmod_for_each_by_class.
> I was thinking of keeping the behaviour of these iterators
> same for now and add WARN's in these iterators itself upon
> an error, so its seen even if the user fails to catch it.

What's your opinion on adding the pr_err() or WARN() into the code that
the iterator calls for each hwmod? That code should know why something
fails, so it should be able to provide a more detailed error message. Of
course, it is not as general a solution...

- Paul