Re: [PATCH 2/3] OMAP2+: hwmod: Fix what _init_clock returns

Cousson, Benoit
2011-02-18T14:51:47Z

On 2/16/2011 1:11 PM, Nayak, Rajendra wrote:
> _init_clock always returns 0 and does
> not propogate the error (in case of failure)
> back to the caller, causing _init_clocks to
> fail silently.
>
> Signed-off-by: Rajendra Nayak<rnayak@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index cd9dcde..960461f 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -926,7 +926,7 @@ static int _init_clocks(struct omap_hwmod *oh, void *data)
> if (!ret)
> oh->_state = _HWMOD_STATE_CLKS_INITED;
>
> - return 0;
> + return ret;
> }
>
> /**

This is correct and that makes kerneldoc accurate : "Returns ... a
non-zero error on failure."

I'll queue it for 2.6.39.

Thanks,
Benoit