Re: [PATCH 1/3] OMAP2+: hwmod: Avoid setup if clock lookup failed

Sergei Shtylyov
2011-02-16T12:36:46Z

Hello.

On 16.02.2011 15:11, Rajendra Nayak wrote:

> Add a hwmod state check in the _setup function
> to avoid setting up hwmods' for which clock
> lookup has failed.

> Signed-off-by: Rajendra Nayak<rnayak@ti.com>
[...]

> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index e282e35..cd9dcde 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -1362,6 +1362,12 @@ static int _setup(struct omap_hwmod *oh, void *data)
> int i, r;
> u8 postsetup_state;
>
> + if (oh->_state != _HWMOD_STATE_CLKS_INITED) {
> + WARN(1, "omap_hwmod: %s: _setup failed as one or more"

You forgot space bafore " -- "moreclock" will be printed.

> + "clock lookups' have failed\n", oh->name);

Why there's apostrophe here?

WBR, Sergei