From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe() Date: Tue, 22 Aug 2017 15:39:38 -0500 Message-ID: <6de244a4-8efb-95c4-ff4b-ab9221ef5751@embeddedor.com> References: <20170809161603.GA31297@embeddedgus> <20170822203750.GF6948@bhelgaas-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170822203750.GF6948@bhelgaas-glaptop.roam.corp.google.com> Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: Kishon Vijay Abraham I , Bjorn Helgaas , linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org Hi Bjorn, On 08/22/2017 03:37 PM, Bjorn Helgaas wrote: > On Wed, Aug 09, 2017 at 11:16:03AM -0500, Gustavo A. R. Silva wrote: >> platform_get_irq() returns an error code, but the pci-dra7xx driver >> ignores it and always returns -EINVAL. This is not correct and, >> prevents -EPROBE_DEFER from being propagated properly. >> >> Print and propagate the return value of platform_get_irq on failure. >> >> This issue was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva > > Applied with Kishon's ack to pci/host-dra7xx for v4.14, thanks! > Glad to help. :) >> --- >> drivers/pci/dwc/pci-dra7xx.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c >> index f2fc5f4..f58e1b4 100644 >> --- a/drivers/pci/dwc/pci-dra7xx.c >> +++ b/drivers/pci/dwc/pci-dra7xx.c >> @@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) >> >> irq = platform_get_irq(pdev, 0); >> if (irq < 0) { >> - dev_err(dev, "missing IRQ resource\n"); >> - return -EINVAL; >> + dev_err(dev, "missing IRQ resource: %d\n", irq); >> + return irq; >> } >> >> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf"); >> -- >> 2.5.0 >> -- Gustavo A. R. Silva