From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3696E11CA0; Sat, 4 Jan 2025 18:21:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736014896; cv=none; b=W8KHmXApPVeLN2GrTmnFxuYUUjNLQtiDHJ/hi1XA/fRLk8eIS8vlveYb6ecv+hVTSNFFllVfx8KXZmapkZsg+cvh6gcfP0/kkfUF1IHmftV1rmEgfK5EtqDwdxwBLaB2FuSMK4iu7DHZIIIfGF+rKh/nKdqwY8x7E8K+3zpcE9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736014896; c=relaxed/simple; bh=5f3JxfPO7OYqOFiAR9R8KYdI/dHjerc/9ZU9e0v/bPo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qiGrK2XioJrrFPXzFnbQxpaLTlLUMivBV4ffxhQJoGGG2QvPrFVaUJuLUW4OZGNYOwFtKnw0O/LIGxCtZvgUSTkwAknHk+XudN2dZETTD/aOMMTWcxlWreBzFo1DZKiqGMSIsGAHH1/jrYbpiH2/DNRyriYzKVuA6UMIavgT2jQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ay2DJ7Me; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ay2DJ7Me" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A087C4CEDE; Sat, 4 Jan 2025 18:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736014894; bh=5f3JxfPO7OYqOFiAR9R8KYdI/dHjerc/9ZU9e0v/bPo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ay2DJ7Me+xOn0Ip4twETX//+9E/F1YXwmVgcSojFUgwoI8xxg/pxZz9zC8Gc49Sp4 ZHY1tbI3IaDLPSO1Ic4kmrEdE7ATkZCTLny/08jvpeekLj0hd3Fm82zZuUc28WYtGF wEwlv8Nc63AP7L8w89v87c8V4ElVorWeBeoydKjzt8axWLpYP7g7CmkpnzY8TkHVrv aTu5oB8lOjtm7rtO6psWJsqB3BM6j/STPBVZYyXx3J7zA5F4T+wbIPopw/4EGYFu9Q hQCKsJSl5rDXVPl9LRww3yQYRDbNFhSOOHzd0ZG3geZLKp1GMK32v/b7qQb8H6uw13 tirHQddjqbmSQ== Message-ID: <707925ce-b76e-470a-921f-7ac165a04d69@kernel.org> Date: Sat, 4 Jan 2025 20:21:29 +0200 Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] gpio: tps65215: Add TPS65215 to platform_device_id table To: Shree Ramamoorthy , aaro.koskinen@iki.fi, andreas@kemnade.info, khilman@baylibre.com, tony@atomide.com, linus.walleij@linaro.org, brgl@bgdev.pl, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Cc: m-leonard@ti.com, praneeth@ti.com, christophe.jaillet@wanadoo.fr References: <20250103225407.196068-1-s-ramamoorthy@ti.com> <20250103225407.196068-2-s-ramamoorthy@ti.com> Content-Language: en-US From: Roger Quadros In-Reply-To: <20250103225407.196068-2-s-ramamoorthy@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/01/2025 00:54, Shree Ramamoorthy wrote: > Add platform_device_id struct and use the platform_get_device_id() output > to match which PMIC device is in use. With new name options, the gpio_chip > .label field is now assigned to the platform_device name match. > > Remove MODULE_ALIAS since it is now generated by MODULE_DEVICE_TABLE. > > Signed-off-by: Shree Ramamoorthy > --- > drivers/gpio/gpio-tps65219.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c > index 526640c39a11..7e03be0c7c92 100644 > --- a/drivers/gpio/gpio-tps65219.c > +++ b/drivers/gpio/gpio-tps65219.c > @@ -1,8 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * GPIO driver for TI TPS65219 PMICs > + * GPIO driver for TI TPS65215/TPS65219 PMICs > * > - * Copyright (C) 2022 Texas Instruments Incorporated - http://www.ti.com/ > + * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/ > */ > > #include > @@ -141,7 +141,6 @@ static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned int off > } > > static const struct gpio_chip tps65219_template_chip = { > - .label = "tps65219-gpio", > .owner = THIS_MODULE, > .get_direction = tps65219_gpio_get_direction, > .direction_input = tps65219_gpio_direction_input, > @@ -164,20 +163,28 @@ static int tps65219_gpio_probe(struct platform_device *pdev) > > gpio->tps = tps; > gpio->gpio_chip = tps65219_template_chip; > + gpio->gpio_chip.label = dev_name(&pdev->dev); > gpio->gpio_chip.parent = tps->dev; > > return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio_chip, gpio); > } > > +static const struct platform_device_id tps6521x_gpio_id_table[] = { > + { "tps65215-gpio", TPS65215 }, > + { "tps65219-gpio", TPS65219 }, > + { } > +}; > +MODULE_DEVICE_TABLE(platform, tps6521x_gpio_id_table); > + > static struct platform_driver tps65219_gpio_driver = { > .driver = { > .name = "tps65219-gpio", > }, > .probe = tps65219_gpio_probe, > + .id_table = tps6521x_gpio_id_table, > }; > module_platform_driver(tps65219_gpio_driver); > > -MODULE_ALIAS("platform:tps65219-gpio"); Why do you drop the MODULE_ALIAS? You can add multiple MODULE_ALIASES if needed. > MODULE_AUTHOR("Jonathan Cormier "); > -MODULE_DESCRIPTION("TPS65219 GPIO driver"); > +MODULE_DESCRIPTION("TPS65215/TPS65219 GPIO driver"); "TPS6521x GPIO driver"? I also see a product named TPS65216. By any chance can that be also supported by this driver? > MODULE_LICENSE("GPL"); -- cheers, -roger