From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shree Ramamoorthy <s-ramamoorthy@ti.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, aaro.koskinen@iki.fi,
andreas@kemnade.info, khilman@baylibre.com, rogerq@kernel.org,
tony@atomide.com, lee@kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: m-leonard@ti.com, praneeth@ti.com
Subject: Re: [PATCH v4 2/5] regulator: dt-bindings: Add TI TPS65214 PMIC bindings
Date: Sat, 1 Feb 2025 12:42:46 +0100 [thread overview]
Message-ID: <746798a0-1a35-4a3f-aa9b-6edfd724bf10@kernel.org> (raw)
In-Reply-To: <20250131221139.342967-3-s-ramamoorthy@ti.com>
On 31/01/2025 23:11, Shree Ramamoorthy wrote:
>
> @@ -98,6 +102,16 @@ required:
> additionalProperties: false
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,tps65214
> + then:
> + properties:
> + regulators:
> + patternProperties:
> + "^ldo[3-4]$": false
So now, when you combined these patches, you can easily see that you are
duplicating your other "then:" from patch #1. Just combine these into
enum. Don't duplicate.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-01 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 22:11 [PATCH v4 0/5] Add TI TPS65214 & TPS65215 PMIC MFD Driver Support Shree Ramamoorthy
2025-01-31 22:11 ` [PATCH v4 1/5] regulator: dt-bindings: Add TI TPS65215 PMIC bindings Shree Ramamoorthy
2025-01-31 22:11 ` [PATCH v4 2/5] regulator: dt-bindings: Add TI TPS65214 " Shree Ramamoorthy
2025-02-01 11:42 ` Krzysztof Kozlowski [this message]
2025-02-04 19:09 ` Shree Ramamoorthy
2025-01-31 22:11 ` [PATCH v4 3/5] mfd: tps65219: Remove regmap_read check Shree Ramamoorthy
2025-01-31 22:11 ` [PATCH v4 4/5] mfd: tps65219: Add support for TI TPS65215 PMIC Shree Ramamoorthy
2025-01-31 22:11 ` [PATCH v4 5/5] mfd: tps65219: Add support for TI TPS65214 PMIC Shree Ramamoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=746798a0-1a35-4a3f-aa9b-6edfd724bf10@kernel.org \
--to=krzk@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-leonard@ti.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-ramamoorthy@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox