Re: [PATCH 08/19] omap3+: sr: make notify independent of class

Kevin Hilman
2011-03-03T00:05:04Z

Nishanth Menon <nm@ti.com> writes:

> Interrupt notification mechanism of SmartReflex can be used by the
> choice of implementation of the class driver. For example, Class 2 and
> Class 1.5 of SmartReflex can both use the interrupt notification to
> identify the transition of voltage or other events.
>
> Hence, the actual class does not matter for notifier. Let the class
> driver's handling decide how it should be used. smartreflex driver
> should provide just the primitives.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Thanks, queueing for 2.6.39 after capitalizing OMAP & SR in subject.

Kevin

> ---
> arch/arm/mach-omap2/smartreflex.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index eba90a4..6f0c7d0 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -142,7 +142,7 @@ static irqreturn_t sr_interrupt(int irq, void *data)
> sr_write_reg(sr_info, IRQSTATUS, status);
> }
>
> - if (sr_class->class_type == SR_CLASS2 && sr_class->notify)
> + if (sr_class->notify)
> sr_class->notify(sr_info->voltdm, status);
>
> return IRQ_HANDLED;
> @@ -257,9 +257,7 @@ static int sr_late_init(struct omap_sr *sr_info)
> struct resource *mem;
> int ret = 0;
>
> - if (sr_class->class_type == SR_CLASS2 &&
> - sr_class->notify_flags && sr_info->irq) {
> -
> + if (sr_class->notify && sr_class->notify_flags && sr_info->irq) {
> name = kasprintf(GFP_KERNEL, "sr_%s", sr_info->voltdm->name);
> if (name == NULL) {
> ret = -ENOMEM;