Re: [PATCH 16/19] omap3+: sr: disable spamming interrupts

Kevin Hilman
2011-03-03T00:21:54Z

Nishanth Menon <nm@ti.com> writes:

> At times with bad SR configurations especially during silicon bringups,
> we could get continuous spurious interrupts which end up hanging the
> platform in the form of an ISR call for status bits that are
> automatically enabled by the h/w without any s/w clearing option.
>
> If we detect scenarios where isr was called without the corresponding

minor: please capitalize ISR consistently throughout.

> notification bit being set, instead of hanging up the system,
> we will disable interrupt after noting the event in the system log
> to try and keep system sanity and allow developer to debug and fix
> the condition.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

otherwise, patch looks fine.

Kevin

> ---
> arch/arm/mach-omap2/smartreflex.c | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index ad23b8d..0301186 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -209,8 +209,16 @@ static irqreturn_t sr_interrupt(int irq, void *data)
> value = irqstat_to_notifier_v2(status);
> }
>
> - if (sr_class->notify)
> - sr_class->notify(sr_info->voltdm, value);
> + /* Attempt some resemblence of recovery! */
> + if (!value) {
> + dev_err(&sr_info->pdev->dev, "%s: Spurious interrupt!"
> + "status = 0x%08x. Disabling to prevent spamming!!\n",
> + __func__, status);
> + disable_irq_nosync(sr_info->irq);
> + } else {
> + if (sr_class->notify)
> + sr_class->notify(sr_info->voltdm, value);
> + }
>
> return IRQ_HANDLED;
> }