* [PATCH] video/omap: add module license tags @ 2018-05-28 15:46 ` Arnd Bergmann 2018-06-08 15:57 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Arnd Bergmann @ 2018-05-28 15:46 UTC (permalink / raw) To: Tomi Valkeinen, Bartlomiej Zolnierkiewicz Cc: Arnd Bergmann, Imre Deak, Krzysztof Kozlowski, Wolfram Sang, linux-fbdev, linux-omap, dri-devel, linux-kernel I got a bunch of warnings in a randconfig build: WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/omap/lcd_ams_delta.o WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/omap/lcd_inn1510.o WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/omap/lcd_palmte.o WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/omap/lcd_palmtt.o These come from an earlier patch of mine that turned all display drivers into separate modules. The fix is to add a MODULE_LICENSE tag. Since I'm doing that, adding a description and author field also makes sense. I went by the authors listed in the comment at the top of each file, but removed Imre's Nokia email address that I assume is not valid any more, since Imre is working at Intel these days. Fixes: 81c44c2b2ce3 ("video/omap: fix modular build") Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/video/fbdev/omap/lcd_ams_delta.c | 3 +++ drivers/video/fbdev/omap/lcd_h3.c | 3 +++ drivers/video/fbdev/omap/lcd_htcherald.c | 4 ++++ drivers/video/fbdev/omap/lcd_inn1510.c | 3 +++ drivers/video/fbdev/omap/lcd_inn1610.c | 3 +++ drivers/video/fbdev/omap/lcd_osk.c | 4 ++++ drivers/video/fbdev/omap/lcd_palmte.c | 3 +++ drivers/video/fbdev/omap/lcd_palmtt.c | 3 +++ drivers/video/fbdev/omap/lcd_palmz71.c | 3 +++ 9 files changed, 29 insertions(+) diff --git a/drivers/video/fbdev/omap/lcd_ams_delta.c b/drivers/video/fbdev/omap/lcd_ams_delta.c index a4ee947006c7..488b3e9a2646 100644 --- a/drivers/video/fbdev/omap/lcd_ams_delta.c +++ b/drivers/video/fbdev/omap/lcd_ams_delta.c @@ -197,3 +197,6 @@ static struct platform_driver ams_delta_panel_driver = { }; module_platform_driver(ams_delta_panel_driver); +MODULE_AUTHOR("Jonathan McDowell <noodles@earth.li>"); +MODULE_DESCRIPTION("LCD panel support for the Amstrad E3 (Delta) videophone"); +MODULE_LICENSE("GPL"); diff --git a/drivers/video/fbdev/omap/lcd_h3.c b/drivers/video/fbdev/omap/lcd_h3.c index 796f4634c4c6..146dd962c69e 100644 --- a/drivers/video/fbdev/omap/lcd_h3.c +++ b/drivers/video/fbdev/omap/lcd_h3.c @@ -89,3 +89,6 @@ static struct platform_driver h3_panel_driver = { }; module_platform_driver(h3_panel_driver); +MODULE_AUTHOR("Imre Deak"); +MODULE_DESCRIPTION("LCD panel support for the TI OMAP H3 board"); +MODULE_LICENSE("GPL"); diff --git a/drivers/video/fbdev/omap/lcd_htcherald.c b/drivers/video/fbdev/omap/lcd_htcherald.c index 9d692f5b8025..db4ff1c6add9 100644 --- a/drivers/video/fbdev/omap/lcd_htcherald.c +++ b/drivers/video/fbdev/omap/lcd_htcherald.c @@ -66,3 +66,7 @@ static struct platform_driver htcherald_panel_driver = { }; module_platform_driver(htcherald_panel_driver); + +MODULE_AUTHOR("Cory Maccarrone"); +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("LCD panel support for the HTC Herald"); diff --git a/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c index b284050f5471..8c334858f441 100644 --- a/drivers/video/fbdev/omap/lcd_inn1510.c +++ b/drivers/video/fbdev/omap/lcd_inn1510.c @@ -73,3 +73,6 @@ static struct platform_driver innovator1510_panel_driver = { }; module_platform_driver(innovator1510_panel_driver); +MODULE_AUTHOR("Imre Deak"); +MODULE_DESCRIPTION("LCD panel support for the TI OMAP1510 Innovator board"); +MODULE_LICENSE("GPL"); diff --git a/drivers/video/fbdev/omap/lcd_inn1610.c b/drivers/video/fbdev/omap/lcd_inn1610.c index 1841710e796f..9ca17b33d382 100644 --- a/drivers/video/fbdev/omap/lcd_inn1610.c +++ b/drivers/video/fbdev/omap/lcd_inn1610.c @@ -106,3 +106,6 @@ static struct platform_driver innovator1610_panel_driver = { }; module_platform_driver(innovator1610_panel_driver); +MODULE_AUTHOR("Imre Deak"); +MODULE_DESCRIPTION("LCD panel support for the TI OMAP1610 Innovator board"); +MODULE_LICENSE("GPL"); diff --git a/drivers/video/fbdev/omap/lcd_osk.c b/drivers/video/fbdev/omap/lcd_osk.c index b0be5771fe90..6545de8f6390 100644 --- a/drivers/video/fbdev/omap/lcd_osk.c +++ b/drivers/video/fbdev/omap/lcd_osk.c @@ -93,3 +93,7 @@ static struct platform_driver osk_panel_driver = { }; module_platform_driver(osk_panel_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Imre Deak"); +MODULE_DESCRIPTION("LCD panel support for the TI OMAP OSK board"); diff --git a/drivers/video/fbdev/omap/lcd_palmte.c b/drivers/video/fbdev/omap/lcd_palmte.c index cef96386cf80..1d442c19799c 100644 --- a/drivers/video/fbdev/omap/lcd_palmte.c +++ b/drivers/video/fbdev/omap/lcd_palmte.c @@ -59,3 +59,6 @@ static struct platform_driver palmte_panel_driver = { }; module_platform_driver(palmte_panel_driver); +MODULE_AUTHOR("Romain Goyet <r.goyet@gmail.com>"); +MODULE_DESCRIPTION("LCD panel support for the Palm Tungsten E"); +MODULE_LICENSE("GPL"); diff --git a/drivers/video/fbdev/omap/lcd_palmtt.c b/drivers/video/fbdev/omap/lcd_palmtt.c index 627f13dae5ad..0b9f17a0fafe 100644 --- a/drivers/video/fbdev/omap/lcd_palmtt.c +++ b/drivers/video/fbdev/omap/lcd_palmtt.c @@ -72,3 +72,6 @@ static struct platform_driver palmtt_panel_driver = { }; module_platform_driver(palmtt_panel_driver); +MODULE_AUTHOR("Marek Vasut <marek.vasut@gmail.com>"); +MODULE_DESCRIPTION("LCD panel support for Palm Tungsten|T"); +MODULE_LICENSE("GPL"); diff --git a/drivers/video/fbdev/omap/lcd_palmz71.c b/drivers/video/fbdev/omap/lcd_palmz71.c index c46d4db1f839..d7071578d70e 100644 --- a/drivers/video/fbdev/omap/lcd_palmz71.c +++ b/drivers/video/fbdev/omap/lcd_palmz71.c @@ -66,3 +66,6 @@ static struct platform_driver palmz71_panel_driver = { }; module_platform_driver(palmz71_panel_driver); +MODULE_AUTHOR("Marek Vasut"); +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("LCD panel support for the Palm Zire71"); -- 2.9.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video/omap: add module license tags 2018-05-28 15:46 ` [PATCH] video/omap: add module license tags Arnd Bergmann @ 2018-06-08 15:57 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-06-08 15:57 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-fbdev, Wolfram Sang, linux-kernel, Krzysztof Kozlowski, Tomi Valkeinen, dri-devel, linux-omap On Monday, May 28, 2018 05:46:19 PM Arnd Bergmann wrote: > I got a bunch of warnings in a randconfig build: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/omap/lcd_ams_delta.o > WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/omap/lcd_inn1510.o > WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/omap/lcd_palmte.o > WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/omap/lcd_palmtt.o > > These come from an earlier patch of mine that turned all display drivers > into separate modules. The fix is to add a MODULE_LICENSE tag. Since I'm > doing that, adding a description and author field also makes sense. I > went by the authors listed in the comment at the top of each file, but > removed Imre's Nokia email address that I assume is not valid any more, > since Imre is working at Intel these days. > > Fixes: 81c44c2b2ce3 ("video/omap: fix modular build") > Cc: Imre Deak <imre.deak@intel.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch queued for 4.18 (with minor fixups, interdiff below), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics diff -u b/drivers/video/fbdev/omap/lcd_ams_delta.c b/drivers/video/fbdev/omap/lcd_ams_delta.c --- b/drivers/video/fbdev/omap/lcd_ams_delta.c +++ b/drivers/video/fbdev/omap/lcd_ams_delta.c 2018-06-08 17:39:29.739986550 +0200 @@ -197,6 +197,7 @@ }; module_platform_driver(ams_delta_panel_driver); + MODULE_AUTHOR("Jonathan McDowell <noodles@earth.li>"); MODULE_DESCRIPTION("LCD panel support for the Amstrad E3 (Delta) videophone"); MODULE_LICENSE("GPL"); diff -u b/drivers/video/fbdev/omap/lcd_h3.c b/drivers/video/fbdev/omap/lcd_h3.c --- b/drivers/video/fbdev/omap/lcd_h3.c +++ b/drivers/video/fbdev/omap/lcd_h3.c 2018-06-08 17:39:41.323986842 +0200 @@ -89,6 +89,7 @@ }; module_platform_driver(h3_panel_driver); + MODULE_AUTHOR("Imre Deak"); MODULE_DESCRIPTION("LCD panel support for the TI OMAP H3 board"); MODULE_LICENSE("GPL"); diff -u b/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c --- b/drivers/video/fbdev/omap/lcd_inn1510.c +++ b/drivers/video/fbdev/omap/lcd_inn1510.c 2018-06-08 17:40:29.055988044 +0200 @@ -73,6 +73,7 @@ }; module_platform_driver(innovator1510_panel_driver); + MODULE_AUTHOR("Imre Deak"); MODULE_DESCRIPTION("LCD panel support for the TI OMAP1510 Innovator board"); MODULE_LICENSE("GPL"); diff -u b/drivers/video/fbdev/omap/lcd_inn1610.c b/drivers/video/fbdev/omap/lcd_inn1610.c --- b/drivers/video/fbdev/omap/lcd_inn1610.c +++ b/drivers/video/fbdev/omap/lcd_inn1610.c 2018-06-08 17:40:40.851988341 +0200 @@ -106,6 +106,7 @@ }; module_platform_driver(innovator1610_panel_driver); + MODULE_AUTHOR("Imre Deak"); MODULE_DESCRIPTION("LCD panel support for the TI OMAP1610 Innovator board"); MODULE_LICENSE("GPL"); diff -u b/drivers/video/fbdev/omap/lcd_osk.c b/drivers/video/fbdev/omap/lcd_osk.c --- b/drivers/video/fbdev/omap/lcd_osk.c +++ b/drivers/video/fbdev/omap/lcd_osk.c 2018-06-08 17:40:55.163988701 +0200 @@ -97,3 +97,3 @@ -MODULE_LICENSE("GPL"); MODULE_AUTHOR("Imre Deak"); MODULE_DESCRIPTION("LCD panel support for the TI OMAP OSK board"); +MODULE_LICENSE("GPL"); diff -u b/drivers/video/fbdev/omap/lcd_palmte.c b/drivers/video/fbdev/omap/lcd_palmte.c --- b/drivers/video/fbdev/omap/lcd_palmte.c +++ b/drivers/video/fbdev/omap/lcd_palmte.c 2018-06-08 17:41:13.839989172 +0200 @@ -60,5 +60,5 @@ module_platform_driver(palmte_panel_driver); -MODULE_AUTHOR("Romain Goyet <r.goyet@gmail.com>"); +MODULE_AUTHOR("Romain Goyet <r.goyet@gmail.com>, Laurent Gonzalez <palmte.linux@free.fr>"); MODULE_DESCRIPTION("LCD panel support for the Palm Tungsten E"); MODULE_LICENSE("GPL"); diff -u b/drivers/video/fbdev/omap/lcd_palmtt.c b/drivers/video/fbdev/omap/lcd_palmtt.c --- b/drivers/video/fbdev/omap/lcd_palmtt.c +++ b/drivers/video/fbdev/omap/lcd_palmtt.c 2018-06-08 17:42:30.855991111 +0200 @@ -72,6 +72,7 @@ }; module_platform_driver(palmtt_panel_driver); + MODULE_AUTHOR("Marek Vasut <marek.vasut@gmail.com>"); MODULE_DESCRIPTION("LCD panel support for Palm Tungsten|T"); MODULE_LICENSE("GPL"); diff -u b/drivers/video/fbdev/omap/lcd_palmz71.c b/drivers/video/fbdev/omap/lcd_palmz71.c --- b/drivers/video/fbdev/omap/lcd_palmz71.c +++ b/drivers/video/fbdev/omap/lcd_palmz71.c 2018-06-08 17:43:16.543992262 +0200 @@ -67,5 +67,5 @@ module_platform_driver(palmz71_panel_driver); -MODULE_AUTHOR("Marek Vasut"); +MODULE_AUTHOR("Romain Goyet, Laurent Gonzalez, Marek Vasut"); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("LCD panel support for the Palm Zire71"); _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-08 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180528154724epcas4p2a7e53a8a3ee382375f23328f9b8bd823@epcas4p2.samsung.com>
2018-05-28 15:46 ` [PATCH] video/omap: add module license tags Arnd Bergmann
2018-06-08 15:57 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).