From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH V2 4/7] ARM: OMAP2+: powerdomain: introduce logic for finding valid power domain Date: Wed, 27 Aug 2014 13:25:43 -0700 Message-ID: <7h1ts1bry0.fsf@paris.lan> References: <1408715373-25791-1-git-send-email-nm@ti.com> <1409165694-26568-1-git-send-email-nm@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f49.google.com ([209.85.220.49]:64892 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935735AbaH0UZq (ORCPT ); Wed, 27 Aug 2014 16:25:46 -0400 Received: by mail-pa0-f49.google.com with SMTP id hz1so1208064pad.36 for ; Wed, 27 Aug 2014 13:25:45 -0700 (PDT) In-Reply-To: <1409165694-26568-1-git-send-email-nm@ti.com> (Nishanth Menon's message of "Wed, 27 Aug 2014 13:54:54 -0500") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Nishanth Menon Cc: Tony Lindgren , Santosh Shilimkar , Paul Walmsley , Tero Kristo , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, j-keerthy@ti.com, bcousson@baylibre.com Nishanth Menon writes: > powerdomain configuration in OMAP is done using PWRSTCTRL register for > each power domain. However, PRCM lets us write any value we'd like to > the logic and power domain target states, however the SoC integration > tends to actually function only at a few discrete states. These valid > states are already in our powerdomains_xxx_data.c file. > > So, provide a function to easily query valid low power state that the > power domain is allowed to go to. > > Based on work originally done by Jean Pihet > https://patchwork.kernel.org/patch/1325091/ . There is no attempt to > create a new powerdomain solution here, except fixing issues seen > attempting invalid programming attempts. Future consolidation to the > generic powerdomain framework should consider this requirement as > well. > > Similar solutions have been done in product kernels in the past such > as: > https://android.googlesource.com/kernel/omap.git/+blame/android-omap-panda-3.0/arch/arm/mach-omap2/pm44xx.c > > Reviewed-by: Kevin Hilman > Acked-by: Santosh Shilimkar > Signed-off-by: Nishanth Menon > --- > > Not posting the entire series again and updating just this patch.. > > V2: drop BUG in favor of WARN, picked up Santosh and Kevin's acks. Looks good, thanks, Kevin